Bug 11540 - Increasing test coverage for C4::Charset
Summary: Increasing test coverage for C4::Charset
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Chris Cormack
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 01:14 UTC by Emma Heath
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Proposed patch (917 bytes, patch)
2014-01-14 01:27 UTC, Emma Heath 		Details | Diff | Splinter Review
Bug:11540 increasing coverage of Charset.pm (911 bytes, patch)
2014-01-14 02:37 UTC, Emma Heath 		Details | Diff | Splinter Review
Bug:11540 increasing coverage of Charset.pm (971 bytes, patch)
2014-01-14 02:42 UTC, Tom Houlker 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11540: increasing coverage of Charset.pm (1.00 KB, patch)
2014-01-14 14:45 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 11540: (folowup) add a couple of tests more (2.36 KB, patch)
2014-01-14 14:45 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 11540: increasing coverage of Charset.pm (1019 bytes, patch)
2014-01-14 20:18 UTC, Emma Heath 		Details | Diff | Splinter Review
Bug 11540: (folowup) add a couple of tests more (2.42 KB, patch)
2014-01-14 20:19 UTC, Emma Heath 		Details | Diff | Splinter Review
[PASSED QA] Bug 11540: increasing coverage of Charset.pm (1.07 KB, patch)
2014-01-14 21:12 UTC, Katrin Fischer 		Details | Diff | Splinter Review
[PASSED QA] Bug 11540: (folowup) add a couple of tests more (2.48 KB, patch)
2014-01-14 21:12 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emma Heath 2014-01-14 01:14:13 UTC 

    


    


      

          
            
          


        
          Comment 1
        

        
          Emma Heath

        

        
        

        
          2014-01-14 01:27:12 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 2
        

        
          Emma Heath

        

        
        

        
          2014-01-14 02:37:01 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 3
        

        
          Tom Houlker

        

        
        

        
          2014-01-14 02:42:55 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 4
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2014-01-14 14:45:39 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 5
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2014-01-14 14:45:57 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 6
        

        
          Emma Heath

        

        
        

        
          2014-01-14 20:18:26 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      

          
            
          


        
          Comment 7
        

        
          Emma Heath

        

        
        

        
          2014-01-14 20:19:33 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 8
        

        
          Katrin Fischer

        

        
        

        
          2014-01-14 21:12:35 UTC
        

      






Created attachment 24316 [details] [review]
[PASSED QA] Bug 11540: increasing coverage of Charset.pm

To test
1. run prove t/Charset.t
2. apply patch
3. run prove t/Charset.t
 notice more tests are run

Signed-off-by: Tom Houlker <thomas.houlker@hibs.school.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tests pass!

    


    


      



        
          Comment 9
        

        
          Katrin Fischer

        

        
        

        
          2014-01-14 21:12:56 UTC
        

      






Created attachment 24317 [details] [review]
[PASSED QA] Bug 11540: (folowup) add a couple of tests more

This patch makes sure all scenarios are covered for SetUTF8Flag.

Regards
To+

Signed-off-by: Emma Heath <emmaheath.student@wegc.school.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

    


    


      



        
          Comment 10
        

        
          Galen Charlton

        

        
        

        
          2014-01-14 22:15:38 UTC
        

      






Pushed to master.  Congratulations on having your first patch accepted to Koha, Emma!

    


    


      



        
          Comment 11
        

        
          Tomás Cohen Arazi (tcohen)

        

        
        

        
          2014-02-07 16:03:07 UTC
        

      






This patch has been pushed to 3.12.x, will be in 3.12.11.

Thanks and congratulations Emma!