Bug 11545 - Increasing test coverage for C4::Languages
Summary: Increasing test coverage for C4::Languages
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Cormack
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-14 01:16 UTC by Merllissia Manueli
Modified: 2014-12-07 20:07 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.03 KB, patch)
2014-01-14 01:27 UTC, Merllissia Manueli
Details | Diff | Splinter Review
bug 11545 Increasing test coverage for Languages.pm To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run (1.06 KB, patch)
2014-01-14 02:29 UTC, AlexHorsman
Details | Diff | Splinter Review
[SIGNED-OFF] bug 11545 Increasing test coverage for Languages.pm (1.22 KB, patch)
2014-01-14 20:05 UTC, Magnus Enger
Details | Diff | Splinter Review
[PASSED QA] bug 11545 Increasing test coverage for Languages.pm (1.29 KB, patch)
2014-01-14 20:25 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Merllissia Manueli 2014-01-14 01:16:15 UTC

    
Comment 1 Merllissia Manueli 2014-01-14 01:27:38 UTC Comment hidden (obsolete)
Comment 2 AlexHorsman 2014-01-14 02:29:39 UTC Comment hidden (obsolete)
Comment 3 Magnus Enger 2014-01-14 20:05:46 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-01-14 20:25:30 UTC
Created attachment 24308 [details] [review]
[PASSED QA] bug 11545 Increasing test coverage for Languages.pm

To test 1. Run prove t/Languages.t Apply patch 2. Run prove t/Languages.t Notice: More tests are run

Signed-off-by: alex_h <dhorsman@xtra.co.nz>
Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Adds another passing test. I took th liberty of moving the test plan
from the subject to the commit message. :-)

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tests pass :)
Comment 5 Galen Charlton 2014-01-14 20:51:11 UTC
Pushed to master, along with a follow-up that moves Languages.t to t/db_dependent.  That signals that the test script requires that there be a Koha database to connect to, as is required in order to test getAllLanguages().

Congratulations on having your first patch accepted into Koha, Merllissia!