Bug 11567 - Shortcut is searching with every keypress
Summary: Shortcut is searching with every keypress
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low major
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
: 11712 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-01-16 08:26 UTC by Nicholas van Oudtshoorn
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas van Oudtshoorn 2014-01-16 08:26:11 UTC 
Just updated to 3.14.1, and noticed that any keypress (including F3!!) anywhere on most staff pages (including in input fields in the system preferences) activates the "Search" shortcut.

For instance, in system preferences, if you try and search for a system preference, you start typing and it instead types one letter into the "Search the catalogue" field and then does the search.

This makes the staff interface quite useless IMHO.

A simple fix - I think, not sure if it's right - is to set the default_option for "disable_in_input" to true in /intranet-tmpl/lib/shortcut/shortcut.js. THat is:

        var default_options = {
            'type':'keydown',
            'propagate':false,
            'disable_in_input':true,
            'target':document,
            'keycode':false
        }
Comment 1 Owen Leonard 2014-01-16 14:09:41 UTC 
I can't reproduce this problem in Firefox 26 or Chrome 31 on Windows 7. Please try clearing your browser cache. If the problem persists, please reply with your operating system and browser version.
Comment 2 Magnus Enger 2014-01-16 14:12:57 UTC 
I had something like this, when i was using the Norwegian translation. The problem seemed to be caused by me upgrading Koha but forgetting to update the templates (sudo koha-translate -u nb-NO). After I updated the translated templates, the problem disappeared.
Comment 3 Tomás Cohen Arazi (tcohen) 2014-01-16 14:32:35 UTC 
This might have been caused by bug 11035 being pushed to stable (3.14.x) and published with 3.14.1 and thus people that forgot to update its template translations had this sympthoms.
Comment 4 Liz Rea 2014-01-17 09:48:04 UTC 
I have seen this as well, related to translations, but it seems fixed in 3.14.1 and master.

Clearing cache normally makes it go away for me (after the templates are updated).
Comment 5 Nicholas van Oudtshoorn 2014-01-23 02:24:27 UTC 
Hmmm - it seems to be working now. I'll remember that tip about updating templates.

I'm not running the debian packages (we're a Fedora shop here).
Comment 6 Chris Cormack 2014-02-15 08:17:18 UTC 
*** Bug 11712 has been marked as a duplicate of this bug. ***