Bug 11588 - Untranslatable subscription frequency units
Summary: Untranslatable subscription frequency units
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: paxed
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-21 06:46 UTC by paxed
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11588 - Untranslatable subscription frequency units (5.23 KB, patch)
2014-01-30 15:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Allow translating the subscription frequency units in the template (2.02 KB, patch)
2014-04-24 10:28 UTC, paxed
Details | Diff | Splinter Review
Bug 11588: Untranslatable subscription frequency units (2.07 KB, patch)
2014-04-24 15:30 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11588: Untranslatable subscription frequency units (2.13 KB, patch)
2014-04-25 14:18 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-01-21 06:46:32 UTC
When eg. editing or creating a new subscription frequency, a drop-down lists the possible units for the frequency. These are not translatable, as they're hard-coded eg. in GetFictiveIssueNumber() in C4/Serials.pm ('day', 'week', 'month', 'year')
Comment 1 Owen Leonard 2014-01-30 15:44:20 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2014-01-30 15:49:20 UTC
Comment on attachment 24892 [details] [review]
Bug 11588 - Untranslatable subscription frequency units

Never mind, this method won't work with translated values in the database.
Comment 3 paxed 2014-04-24 10:28:58 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2014-04-24 15:30:42 UTC Comment hidden (obsolete)
Comment 5 Kyle M Hall 2014-04-25 14:18:58 UTC
Created attachment 27630 [details] [review]
[PASSED QA] Bug 11588: Untranslatable subscription frequency units

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Galen Charlton 2014-04-25 15:41:42 UTC
Pushed to master.  Thanks, Pasi!