For each language in the installation, there's a mandatory subtag_registry.sql -file, that contains the language names. Each of those files contain the same language information. This is unnecessary duplication, and makes adding new install languages harder, because the same information needs to be added to each of those files.
Created attachment 26772 [details] [review] Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR
Created attachment 32783 [details] [review] Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 32806 [details] [review] [PASSED QA] Bug 11593 - subtag_registry.sql files contain the same information for each language This patch removes subtag_registry.sql from lang dirs, and put it on a new mandatory dir In that way we need to update only one file. All similar files are removed. To test: 1) Try a new install, or simply create a new database, grant permissions on it, change koha-conf.xml to use this database and go to staff page 2) Go step by step until all mandatory or optional sql files are loaded. Check that subtag_registry.sql is loaded. 3) Do it again but on other language. First install translation and repeat 2), could use de-DE or fr-FR Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, tested with de-DE. Thx!
Created attachment 32807 [details] [review] Bug 11593: Remove subtag_registry.txt This file is no longer needed by the web installer and can be deleted.
Bernardo, what do you think about removing the text file (see second patch)?
Patch pushed to master. Thanks Bernardo!
(In reply to Katrin Fischer from comment #5) > Bernardo, what do you think about removing the text file (see second patch)? It's only a description, could be removed... and it's already done :) I will rework Bug 12250 and complete missing language descriptions
Tomas was fast :) Hope you don't mind!