It is quite common that new major releases introduce new configuration entries in the koha-conf.xml file. Users carrying old koha-conf.xml files usually miss those configuration entries. We usually fallback to some default when the configuration entry is missing. The user should be warnig that a fallback to some default is being done and that it could have consequences in a near future. It will help debug users' problems.
Created attachment 24608 [details] [review] Bug 11596: Missing indexing options in koha-conf.xml should be reported To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Apply the patch - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Edit your koha-conf.xml file commenting one or both indexing mode entries. - Go to More > About Koha > System information => You get "XML configuration file" warnings for each commented entry. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Created attachment 24632 [details] [review] [SIGNED OFF] Bug 11596: Missing indexing options in koha-conf.xml should be reported To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Apply the patch - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Edit your koha-conf.xml file commenting one or both indexing mode entries. - Go to More > About Koha > System information => You get "XML configuration file" warnings for each commented entry. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 24673 [details] [review] Bug 11596: Missing indexing options in koha-conf.xml should be reported To test: - Have a clean master install - Verify that koha-conf.xml contains valid entries for: zebra_bib_index_mode and zebra_auth_index_mode - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Apply the patch - Go to More > About Koha > System information => No "Warnings regarding the system configuration" - Edit your koha-conf.xml file commenting one or both indexing mode entries. - Go to More > About Koha > System information => You get "XML configuration file" warnings for each commented entry. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 24674 [details] [review] Bug 11596: Fix ergonomic issue If you had a warning on preference, the warning on the config file did not appear. To reproduce, without this patch: - switch on OPACPrivacy and set AnonymousPatron to 0. - comment at least 1 zebra_*_index_mode in your config file. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Tomás, I provide a followup, could you agree or not with it please?
Created attachment 24679 [details] [review] Bug 11596: Fix ergonomic issue If you had a warning on preference, the warning on the config file did not appear. To reproduce, without this patch: - switch on OPACPrivacy and set AnonymousPatron to 0. - comment at least 1 zebra_*_index_mode in your config file. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Pushed to master. Thank, Tomás! I note that the display logic for system configuration warnings is unnecessarily complicated and ought to be simplified.