Bug 11596 - Missing indexing options in koha-conf.xml should be reported
Summary: Missing indexing options in koha-conf.xml should be reported
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-22 14:25 UTC by Tomás Cohen Arazi
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11596: Missing indexing options in koha-conf.xml should be reported (3.51 KB, patch)
2014-01-22 14:32 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11596: Missing indexing options in koha-conf.xml should be reported (3.57 KB, patch)
2014-01-22 23:51 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11596: Missing indexing options in koha-conf.xml should be reported (3.62 KB, patch)
2014-01-24 11:37 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11596: Fix ergonomic issue (6.44 KB, patch)
2014-01-24 11:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11596: Fix ergonomic issue (6.49 KB, patch)
2014-01-24 12:23 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-01-22 14:25:46 UTC
It is quite common that new major releases introduce new configuration entries in the koha-conf.xml file. Users carrying old koha-conf.xml files usually miss those configuration entries.

We usually fallback to some default when the configuration entry is missing. The user should be warnig that a fallback to some default is being done and that it could have consequences in a near future.

It will help debug users' problems.
Comment 1 Tomás Cohen Arazi 2014-01-22 14:32:35 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-01-22 23:51:14 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-01-24 11:37:56 UTC
Created attachment 24673 [details] [review]
Bug 11596: Missing indexing options in koha-conf.xml should be reported

To test:
- Have a clean master install
- Verify that koha-conf.xml contains valid entries for:
  zebra_bib_index_mode and
  zebra_auth_index_mode
- Go to More > About Koha > System information
=> No "Warnings regarding the system configuration"
- Apply the patch
- Go to More > About Koha > System information
=> No "Warnings regarding the system configuration"
- Edit your koha-conf.xml file commenting one or both indexing mode
  entries.
- Go to More > About Koha > System information
=> You get "XML configuration file" warnings for each commented entry.
- Sign off :-D

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-01-24 11:38:03 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-01-24 11:38:46 UTC
Tomás, I provide a followup, could you agree or not with it please?
Comment 6 Tomás Cohen Arazi 2014-01-24 12:23:28 UTC
Created attachment 24679 [details] [review]
Bug 11596: Fix ergonomic issue

If you had a warning on preference, the warning on the config file did
not appear.

To reproduce, without this patch:
- switch on OPACPrivacy and set AnonymousPatron to 0.
- comment at least 1 zebra_*_index_mode in your config file.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Comment 7 Galen Charlton 2014-04-20 17:08:44 UTC
Pushed to master.  Thank, Tomás!

I note that the display logic for system configuration warnings is unnecessarily complicated and ought to be simplified.