Bug 11608 - don't need the word 'library' on funds
Summary: don't need the word 'library' on funds
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Nicole C. Engard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/acqui-home.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-24 14:29 UTC by Nicole C. Engard
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Library 2 times (22.11 KB, image/png)
2014-01-24 14:34 UTC, Nicole C. Engard
Details
[Bug 11608] Remove the word 'library' from funds list (1.55 KB, patch)
2014-01-24 14:37 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 11608: Remove the word 'library' from funds list (1.62 KB, patch)
2014-01-24 15:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11608: Remove the word 'library' from funds list (1.65 KB, patch)
2014-01-24 15:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11608: Delete unused commented lines in template (1.26 KB, patch)
2014-01-24 15:09 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 11608: Remove the word 'library' from funds list (1.73 KB, patch)
2014-01-25 08:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 11608: Delete unused commented lines in template (1.37 KB, patch)
2014-01-25 08:50 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-01-24 14:29:28 UTC
Most libraries have the word library in their name - and even if they don't showing 'library' next to the library's name is not really necessary on the list of acq funds.
Comment 1 Nicole C. Engard 2014-01-24 14:34:00 UTC
Created attachment 24694 [details]
Library 2 times
Comment 2 Nicole C. Engard 2014-01-24 14:37:19 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-01-24 15:04:47 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-01-24 15:09:03 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2014-01-24 15:09:10 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-01-25 08:50:30 UTC
Created attachment 24727 [details] [review]
[PASSED QA] Bug 11608: Remove the word 'library' from funds list

The list of funds on the main acq page shows the library's name
followed by the word 'library'. I don't think this word is necessary
as most libraries have the word 'library' in their names. Even
if they don't they probably just want their library name to show
without extra words.

To test:

* Visit the acquisitions module before applying
* See the library's name + 'library' above the funds list
* Apply patch
* Look again at funds list and 'library' should be gone

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Amended patch: remove a space

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.
Comment 7 Katrin Fischer 2014-01-25 08:50:40 UTC
Created attachment 24728 [details] [review]
[PASSED QA] Bug 11608: Delete unused commented lines in template

On the way, these lines are commented and can be deleted safely.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Removes an HTML comment with unused code.
Comment 8 Galen Charlton 2014-01-26 15:24:01 UTC
Pushed to master. Thanks, Nicole!
Comment 9 Fridolin Somers 2014-05-07 17:16:39 UTC
Pushed to 3.14.x, will be in 3.14.07
Comment 10 Kyle M Hall 2014-06-06 13:49:12 UTC
Pushed to 3.12.x will be in 3.12.13