All references to tablesorter could be removed.
Created attachment 24740 [details] [review] Bug 11616: tablesorter is no longer in use DataTables has replaced the tablesorter plugin to sort tables into Koha. There is no table using this plugin and all references could be removed. Test plan: - Verify there is no regression on the circ/bookcount.pl tables and that git grep tablesorter does no return any use of this plugin.
Does this mean that ./koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css doesn't need that /* Tablesorter */ section? And is this at all related to the UseTablesortForCirc system preference?
Created attachment 24785 [details] [review] [SIGNED OFF] Bug 11616: tablesorter is no longer in use DataTables has replaced the tablesorter plugin to sort tables into Koha. There is no table using this plugin and all references could be removed. REVISED TEST PLAN ----------------- 1) Apply the patch 2) Home -> Koha administration -> Authorized values 3) Change the 'Show category:' drop down value, and play with the sorting of columns. -- should sort as expected. 4) Search the catalogue -> look for a biblio with high circulation 5) Click one of the name links. 6) Click the Items tab on the left. 7) Scroll down and click the (View item's checkout history) link in the History area. -- Does the sorting work there too? NOTE: I couldn't find data that generated sortable tables. All my checkouts were 0, for some strange reason. 8) git grep -i tablesorter -- Only a reference in staff-global.css and release texts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 24786 [details] [review] [SIGNED OFF] Bug 11616: tablesorter is no longer in use DataTables has replaced the tablesorter plugin to sort tables into Koha. There is no table using this plugin and all references could be removed. REVISED TEST PLAN ----------------- 1) Apply the patch 2) Home -> Koha administration -> Authorized values 3) Change the 'Show category:' drop down value, and play with the sorting of columns. -- should sort as expected. 4) Search the catalogue -> look for a biblio with high circulation 5) Click one of the name links. 6) Click the Items tab on the left. 7) Scroll down and click the (View item's checkout history) link in the History area. -- There was no sorting prior to the patch, so afterwards it should display the same. 8) git grep -i tablesorter -- Only a reference in staff-global.css and release texts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 24932 [details] [review] Bug 11616: tablesorter is no longer in use DataTables has replaced the tablesorter plugin to sort tables into Koha. There is no table using this plugin and all references could be removed. REVISED TEST PLAN ----------------- 1) Apply the patch 2) Home -> Koha administration -> Authorized values 3) Change the 'Show category:' drop down value, and play with the sorting of columns. -- should sort as expected. 4) Search the catalogue -> look for a biblio with high circulation 5) Click one of the name links. 6) Click the Items tab on the left. 7) Scroll down and click the (View item's checkout history) link in the History area. -- There was no sorting prior to the patch, so afterwards it should display the same. 8) git grep -i tablesorter -- Only a reference in staff-global.css and release texts. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master, along with a follow-up that removes CSS rules used only for tablesorter. Thanks, Jonathan!
Pushed to 3.14.x, will be in 3.14.07.