Bug 11616 - The tablesorter plugin is no longer in use
Summary: The tablesorter plugin is no longer in use
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-27 11:24 UTC by Jonathan Druart
Modified: 2014-12-07 20:05 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11616: tablesorter is no longer in use (32.60 KB, patch)
2014-01-27 11:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11616: tablesorter is no longer in use (33.22 KB, patch)
2014-01-28 05:28 UTC, Mark Tompsett
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11616: tablesorter is no longer in use (33.15 KB, patch)
2014-01-28 05:31 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11616: tablesorter is no longer in use (33.23 KB, patch)
2014-01-31 11:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-01-27 11:24:10 UTC
All references to tablesorter could be removed.
Comment 1 Jonathan Druart 2014-01-27 11:27:07 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-01-28 04:47:04 UTC
Does this mean that
./koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
doesn't need that /* Tablesorter */ section?

And is this at all related to the UseTablesortForCirc system preference?
Comment 3 Mark Tompsett 2014-01-28 05:28:39 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2014-01-28 05:31:05 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2014-01-31 11:19:33 UTC
Created attachment 24932 [details] [review]
Bug 11616: tablesorter is no longer in use

DataTables has replaced the tablesorter plugin to sort tables into Koha.
There is no table using this plugin and all references could be removed.

REVISED TEST PLAN
-----------------
1) Apply the patch
2) Home -> Koha administration -> Authorized values
3) Change the 'Show category:' drop down value, and play with
    the sorting of columns.
   -- should sort as expected.
4) Search the catalogue -> look for a biblio with high circulation
5) Click one of the name links.
6) Click the Items tab on the left.
7) Scroll down and click the (View item's checkout history)
    link in the History area.
   -- There was no sorting prior to the patch, so afterwards
      it should display the same.
8) git grep -i tablesorter
   -- Only a reference in staff-global.css and release texts.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Galen Charlton 2014-01-31 15:37:48 UTC
Pushed to master, along with a follow-up that removes CSS rules used only for tablesorter.  Thanks, Jonathan!
Comment 7 Fridolin Somers 2014-05-16 10:42:22 UTC
Pushed to 3.14.x, will be in 3.14.07.