Created attachment 24745 [details] Untranslatable text in jQuery timepicker The jQuery timepicker plugin has some strings that cannot be translated via Koha i18n toolchain. ("Time", "Hour", "Minute", "Now", "Done", ...)
Created attachment 24755 [details] [review] Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain We handle internationalization of the jQuery datepicker by adding language configuration strings to calendar.inc which can be processed by the translation script. This patch adds a similar configuration file for the timepicker. This patch also upgrades the timepicker plugin to the latest version, minified, and places it outside the prog template directory for global use. The path in templates has been updated accordingly. CSS has been added to more completely hide the controls for seconds, milliseconds, and microseconds. To test, apply the patch and clear your cache so that the browser loads the new version of the jQuery plugin. Confirm that date and time selection still function correctly on the circulation page, the patron detail page, and the offline circulation page (circ/offline.pl). Test at least one datepicker instance which does not use the timepicker. Run translate update on a po file and confirm that the timepicker strings are now present.
Created attachment 25313 [details] [review] Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain We handle internationalization of the jQuery datepicker by adding language configuration strings to calendar.inc which can be processed by the translation script. This patch adds a similar configuration file for the timepicker. This patch also upgrades the timepicker plugin to the latest version, minified, and places it outside the prog template directory for global use. The path in templates has been updated accordingly. CSS has been added to more completely hide the controls for seconds, milliseconds, and microseconds. To test, apply the patch and clear your cache so that the browser loads the new version of the jQuery plugin. Confirm that date and time selection still function correctly on the circulation page, the patron detail page, and the offline circulation page (circ/offline.pl). Test at least one datepicker instance which does not use the timepicker. Run translate update on a po file and confirm that the timepicker strings are now present. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 25345 [details] [review] Bug 11618 - jQuery timepicker is not picked up by the i18n toolchain We handle internationalization of the jQuery datepicker by adding language configuration strings to calendar.inc which can be processed by the translation script. This patch adds a similar configuration file for the timepicker. This patch also upgrades the timepicker plugin to the latest version, minified, and places it outside the prog template directory for global use. The path in templates has been updated accordingly. CSS has been added to more completely hide the controls for seconds, milliseconds, and microseconds. To test, apply the patch and clear your cache so that the browser loads the new version of the jQuery plugin. Confirm that date and time selection still function correctly on the circulation page, the patron detail page, and the offline circulation page (circ/offline.pl). Test at least one datepicker instance which does not use the timepicker. Run translate update on a po file and confirm that the timepicker strings are now present. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Works as expected, no regression found.
Pushed to master. Thanks, Owen!
*** Bug 12049 has been marked as a duplicate of this bug. ***
Pushed to 3.14.x, will be in 3.14.08