Bug 11635 - 995$r defined twice in record.abs
Summary: 995$r defined twice in record.abs
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-29 16:25 UTC by Fridolin Somers
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11635 - 995$r defined twice in record.abs (1.25 KB, patch)
2014-01-29 16:32 UTC, Fridolin Somers 		Details | Diff | Splinter Review
[SIGNED OFF] Bug 11635 - 995$r defined twice in record.abs (1.31 KB, patch)
2014-01-30 04:37 UTC, Mark Tompsett 		Details | Diff | Splinter Review
[PASSED QA] Bug 11635 - 995$r defined twice in record.abs (1.40 KB, patch)
2014-01-31 06:39 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2014-01-29 16:25:43 UTC 
For UNIMARC flavor, in record.abs, 995$r defined twice.
Comment 1 Fridolin Somers 2014-01-29 16:32:05 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-01-30 04:35:10 UTC 
Eyeballing it, I can see it is duplicated.

Branched based on origin/master
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

Applied patch
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

cp ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs.bak
cp ./etc/zebradb/marc_defs/unimarc/biblios/record.abs ~/koha-dev/etc/zebradb/marc_defs/unimarc/biblios/record.abs
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

git reset --hard origin/master
Fully reindexed
OPAC searched for itemtype:dpn and itype:dpn -- 631 results

my reindexing gave my lots of warnings, but it was about indexing tags not found in attset(s). I figure I can ignore those.

I think my test covers it. I'm signing off.
Comment 3 Mark Tompsett 2014-01-30 04:37:44 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-01-31 06:33:02 UTC 
Hi Fridolin, please remember to assign the bug to yourself :)
Comment 5 Katrin Fischer 2014-01-31 06:39:08 UTC 
Created attachment 24918 [details] [review]
[PASSED QA] Bug 11635 - 995$r defined twice in record.abs

For UNIMARC flavor, in record.abs, 995$r defined twice.

Test plan :
- Create a fresh install UNIMARC flavor and GRS1 indexing for biblios
- Re-indexe database
- Perform a search with index "itemtype" (and then "itype") on an existing value of 995$r. For example : itemtype:BOOK
=> Check you get results

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Removes duplicated index definition.
Comment 6 Galen Charlton 2014-05-05 02:26:23 UTC 
Pushed to master.  Thanks, Fridolin!