Bug 11647 - Subscribe to email notification for serials needs user login
Summary: Subscribe to email notification for serials needs user login
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P4 normal (vote)
Assignee: Sophie MEYNIEUX
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-31 11:14 UTC by Sophie MEYNIEUX
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11647 : Subscription for email notification on serials asks for login before proceeding (951 bytes, patch)
2014-01-31 11:24 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 11647 : Subscription for email notification on serials asks for login before proceeding (1003 bytes, patch)
2014-02-01 21:12 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list (4.33 KB, patch)
2014-03-10 22:17 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 11647 : Subscription for email notification on serials asks for login before proceeding (1.04 KB, patch)
2014-03-11 11:13 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list (4.38 KB, patch)
2014-03-11 11:13 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11647 : (follow-up) Add template modification for bootstrap theme (3.41 KB, patch)
2014-03-12 14:55 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 11647 : Subscription for email notification on serials asks for login before proceeding (1.09 KB, patch)
2014-03-12 16:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list (4.43 KB, patch)
2014-03-12 16:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 11647 : (follow-up) Add template modification for bootstrap theme (3.47 KB, patch)
2014-03-12 16:08 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
[PASSED QA] Bug 11647 : Subscription for email notification on serials asks for login before proceeding (1.30 KB, patch)
2014-03-13 09:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list (4.50 KB, patch)
2014-03-13 09:43 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 11647 : (follow-up) Add template modification for bootstrap theme (3.53 KB, patch)
2014-03-13 09:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2014-01-31 11:14:54 UTC
It should be mandatory to be logged in on OPAC to subscribe to email notification on new issues for a serial.

This patch does that.

To test : 
- find a serial with notification allowed
- display it on OPAC without being logged in
- click on Subscriptions > Mode details > Subscribe to email notification

Without patch, opac-alert-subscribe.pl is displaid and you can confirm your subscription, but as you are not loggued in, nothing happens and you've got no warning

With the patch, Koha asks you to login before asking confirmation for subscription.
Comment 1 Sophie MEYNIEUX 2014-01-31 11:24:47 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-01 21:12:10 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-02 11:13:24 UTC
Hm, there is something that seems not quite right:

1) Searched for a subscription with patron notification active
2) Logged out of the OPAC
3) Subscribed to the patron notification - it showed the "subscribe" link
4) Logged out of the OPAC again
5) Subscription now always shows "cancel subscription", even when I open
   the page in another browser
6) Logging in with another user account, who hasn't subscribed the alert yet,
   I am still asked to unsubscribe instead of subscribing.
Comment 4 Sophie MEYNIEUX 2014-03-10 22:17:33 UTC Comment hidden (obsolete)
Comment 5 Sophie MEYNIEUX 2014-03-10 22:19:18 UTC
Add a follow up to deal with Katrin objection
Comment 6 Biblibre Sandboxes 2014-03-11 11:13:09 UTC
Patch tested with a sandbox, by remy juliette <remy.gonzalves@iepg.fr>
Comment 7 Biblibre Sandboxes 2014-03-11 11:13:34 UTC Comment hidden (obsolete)
Comment 8 Biblibre Sandboxes 2014-03-11 11:13:38 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2014-03-12 09:43:39 UTC
I am sorry, but I found another complication with this:

1) Subscribe to email alerts
2) Log out of the OPAC
3) Go back to the subscription link - it shows 'subscribe...'
4) Click on the link, it prompts to log you in
5) Log in
6) ... you can subscribe again, there is no note, that you already are
   subscribed to this alert (not quite ok)
7) Check the subscribers list - the borrower now is subscribed twice to the same (not ok)
8) Receive a new issue - 2 emails are sent out (not ok)
9) Unsubscribe - both subscriptions are deleted (ok)
Comment 10 Sophie MEYNIEUX 2014-03-12 14:55:26 UTC Comment hidden (obsolete)
Comment 11 Sophie MEYNIEUX 2014-03-12 14:58:15 UTC
Template modification was missing for bootstrap theme. This last follow-up adds it.

Test plan is the same, with your template system preference on "bootstrap"
Comment 12 Aurélie Fichot 2014-03-12 16:05:48 UTC
It works !
The plan test is OK.

cf comment 9 :
6) ... you can't subscribe again, there is a warm that you already are
   subscribed to this alert
7) Check the subscribers list - the borrower now is subscribed once
8) Receive a new issue - 1 email is sent out
9) Unsubscribe - the subscription is deleted
Comment 13 Biblibre Sandboxes 2014-03-12 16:08:09 UTC
Patch tested with a sandbox, by Aurelie Fichot <aurelie.fichot@iepg.fr>
Comment 14 Biblibre Sandboxes 2014-03-12 16:08:46 UTC Comment hidden (obsolete)
Comment 15 Biblibre Sandboxes 2014-03-12 16:08:50 UTC Comment hidden (obsolete)
Comment 16 Biblibre Sandboxes 2014-03-12 16:08:53 UTC Comment hidden (obsolete)
Comment 17 Katrin Fischer 2014-03-13 09:43:10 UTC
Created attachment 26228 [details] [review]
[PASSED QA] Bug 11647 : Subscription for email notification on serials asks for login before proceeding

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: remy juliette <remy.gonzalves@iepg.fr>
Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and tests.
Instead of hiding the feature completely, now a message
tells the user to login to subscribe to the email
notifications.
Comment 18 Katrin Fischer 2014-03-13 09:43:14 UTC
Created attachment 26229 [details] [review]
[PASSED QA] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list

To test :
1) Search for a subscription with patron notification active
2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues
3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe
4) once you have subscribed, you've got a ling to unsubscribe
5) if you log out, you've got a message saying you must log in to subscribe
6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed.

Signed-off-by: remy juliette <remy.gonzalves@iepg.fr>

Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 19 Katrin Fischer 2014-03-13 09:43:17 UTC
Created attachment 26230 [details] [review]
[PASSED QA] Bug 11647 : (follow-up) Add template modification for bootstrap theme

Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comment 20 Galen Charlton 2014-03-13 15:33:06 UTC
Pushed to master.  Thanks, Sophie!
Comment 21 Fridolin Somers 2014-06-12 07:51:28 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 22 Kyle M Hall 2014-06-13 12:42:49 UTC
Pushed to 3.12.x, will be in 3.12.13