It should be mandatory to be logged in on OPAC to subscribe to email notification on new issues for a serial. This patch does that. To test : - find a serial with notification allowed - display it on OPAC without being logged in - click on Subscriptions > Mode details > Subscribe to email notification Without patch, opac-alert-subscribe.pl is displaid and you can confirm your subscription, but as you are not loggued in, nothing happens and you've got no warning With the patch, Koha asks you to login before asking confirmation for subscription.
Created attachment 24933 [details] [review] Bug 11647 : Subscription for email notification on serials asks for login before proceeding
Created attachment 24979 [details] [review] Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Hm, there is something that seems not quite right: 1) Searched for a subscription with patron notification active 2) Logged out of the OPAC 3) Subscribed to the patron notification - it showed the "subscribe" link 4) Logged out of the OPAC again 5) Subscription now always shows "cancel subscription", even when I open the page in another browser 6) Logging in with another user account, who hasn't subscribed the alert yet, I am still asked to unsubscribe instead of subscribing.
Created attachment 26041 [details] [review] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed.
Add a follow up to deal with Katrin objection
Patch tested with a sandbox, by remy juliette <remy.gonzalves@iepg.fr>
Created attachment 26079 [details] [review] Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: remy juliette <remy.gonzalves@iepg.fr>
Created attachment 26080 [details] [review] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. Signed-off-by: remy juliette <remy.gonzalves@iepg.fr>
I am sorry, but I found another complication with this: 1) Subscribe to email alerts 2) Log out of the OPAC 3) Go back to the subscription link - it shows 'subscribe...' 4) Click on the link, it prompts to log you in 5) Log in 6) ... you can subscribe again, there is no note, that you already are subscribed to this alert (not quite ok) 7) Check the subscribers list - the borrower now is subscribed twice to the same (not ok) 8) Receive a new issue - 2 emails are sent out (not ok) 9) Unsubscribe - both subscriptions are deleted (ok)
Created attachment 26186 [details] [review] Bug 11647 : (follow-up) Add template modification for bootstrap theme
Template modification was missing for bootstrap theme. This last follow-up adds it. Test plan is the same, with your template system preference on "bootstrap"
It works ! The plan test is OK. cf comment 9 : 6) ... you can't subscribe again, there is a warm that you already are subscribed to this alert 7) Check the subscribers list - the borrower now is subscribed once 8) Receive a new issue - 1 email is sent out 9) Unsubscribe - the subscription is deleted
Patch tested with a sandbox, by Aurelie Fichot <aurelie.fichot@iepg.fr>
Created attachment 26197 [details] [review] Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr>
Created attachment 26198 [details] [review] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr>
Created attachment 26199 [details] [review] Bug 11647 : (follow-up) Add template modification for bootstrap theme Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr>
Created attachment 26228 [details] [review] [PASSED QA] Bug 11647 : Subscription for email notification on serials asks for login before proceeding Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes QA script and tests. Instead of hiding the feature completely, now a message tells the user to login to subscribe to the email notifications.
Created attachment 26229 [details] [review] [PASSED QA] Bug 11647 : (follow-up) Test if user is logged in before proposing to subscribe or unscribe from serial routing list To test : 1) Search for a subscription with patron notification active 2) If you're not logged in, a message warns you that you must log in to subscribe to notification on new issues 3) If you log in, and have not yet subscribed to this routing list, you've got a link to subscribe 4) once you have subscribed, you've got a ling to unsubscribe 5) if you log out, you've got a message saying you must log in to subscribe 6) if you log in with another user, you've got the link to subscribe or unsubscribe depending on if he has already subscribed. Signed-off-by: remy juliette <remy.gonzalves@iepg.fr> Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 26230 [details] [review] [PASSED QA] Bug 11647 : (follow-up) Add template modification for bootstrap theme Signed-off-by: Aurelie Fichot <aurelie.fichot@iepg.fr> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Pushed to master. Thanks, Sophie!
Pushed to 3.14.x, will be in 3.14.08
Pushed to 3.12.x, will be in 3.12.13