Bug 11655 - koha-translate --list shouldn't show 'en'
Summary: koha-translate --list shouldn't show 'en'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-01-31 19:42 UTC by Tomás Cohen Arazi
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11655: koha-translate --list shouldn't show 'en' (1.57 KB, patch)
2014-01-31 19:57 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 11655: koha-translate --list shouldn't show 'en' (1.63 KB, patch)
2014-02-01 03:36 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11655: koha-translate --list shouldn't show 'en' (1.69 KB, patch)
2014-02-04 10:48 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2014-01-31 19:42:19 UTC
'en' is not a translation and it doesn't make any sense to return it as part of the installed translations or the available ones.

It becomes relevant to remove it as users upgrading their installed translations end up doing things like this to remove en from the list:

for lang in $(sudo koha-translate --list | grep -v -x en) ; do sudo koha-translate --update $lang ; done

And we do the same in several places too.
Comment 1 Tomás Cohen Arazi 2014-01-31 19:57:31 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-01 03:36:18 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-04 10:48:23 UTC
Created attachment 25018 [details] [review]
Bug 11655: koha-translate --list shouldn't show 'en'

'en' is not a translation and it doesn't make any sense to return it as part of the installed translations or the available ones.

It becomes relevant to remove it as users upgrading their installed translations end up grepping the output to remove 'en' like in:

for lang in $(koha-translate --list | grep -v -x -e 'en') ; do
  koha-translate --update $lang
done

instead of simply issuing the koha-translate --list command.

To test:
- Run
  ./koha-translate --list
  ./koha-translate --list --available
=> It shouldn't return 'en' in the result list.

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-04 17:37:50 UTC
Pushed to master.  Thanks, Tomás!
Comment 5 Fridolin Somers 2014-04-30 14:29:22 UTC
Patch pushed to 3.14.x, will be in 3.14.06