Bug 11673 - columns.def has swapped last and first name of alt contact
Summary: columns.def has swapped last and first name of alt contact
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-04 06:58 UTC by paxed
Modified: 2015-06-04 23:32 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11673: columns.def has swapped last and first name of alt contact (1.88 KB, patch)
2014-08-05 02:17 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[Signed-off] Bug 11673: columns.def has swapped last and first name of alt contact (2.06 KB, patch)
2014-08-05 07:38 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 11673: columns.def has swapped last and first name of alt contact (2.05 KB, patch)
2014-08-07 10:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-02-04 06:58:31 UTC
borrowers.altcontactfirstname   Alternate contact: Last name
borrowers.altcontactsurname     Alternate contact: First name
Comment 1 Tomás Cohen Arazi 2014-08-05 02:17:36 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-08-05 07:38:43 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2014-08-07 10:55:04 UTC
Created attachment 30571 [details] [review]
Bug 11673: columns.def has swapped last and first name of alt contact

To test:
- Create a new guided circulation report
- On the field list scroll to "Alternate contact: Last name"
=> FAIL:
   "Alternate contact: Last name" relates to borrowers.altcontactfirstname
   "Alternate contact: First name" relates to borrowers.altcontactsurname
- Apply the patch, restart the creation of the report
=> SUCCESS:
   "Alternate contact: First name" relates to borrowers.altcontactfirstname
   "Alternate contact: Surname" relates to borrowers.altcontactsurname
- Sign off :-D

Regards
To+

Sponsored-by: Universidad Nacional de Cordoba

Patch behaves as expected
Signed-off-by: Marc Veron <veron@veron.ch>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Tomás Cohen Arazi 2014-08-07 19:58:31 UTC
Patch pushed to master.