Created attachment 25020 [details] [review] Bug 11675: Budget total is not checked if a parent exists The sth is created before the query. The query was modified after the sth creation and an error was raised. Test plan: 0/ Don't apply the patch 1/ Create a budget A (amount=1000) 2/ Create a fund A1 (amount=1000) 3/ Create a child fund A11 (amount=1000) 4/ Edit A11 and change the amount to 2000 You are able to do it, an error appears in the Koha log: "check_parent_total.pl: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed" 5/ Apply the patch, edit A11 and save. You get an error 6/ Edit A11 and change the amount to <=1000 7/ Verify that there is no regression on adding/removing/editing budgets and funds.
Created attachment 25279 [details] [review] Bug 11675: Budget total is not checked if a parent exists The sth is created before the query. The query was modified after the sth creation and an error was raised. Test plan: 0/ Don't apply the patch 1/ Create a budget A (amount=1000) 2/ Create a fund A1 (amount=1000) 3/ Create a child fund A11 (amount=1000) 4/ Edit A11 and change the amount to 2000 You are able to do it, an error appears in the Koha log: "check_parent_total.pl: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed" 5/ Apply the patch, edit A11 and save. You get an error 6/ Edit A11 and change the amount to <=1000 7/ Verify that there is no regression on adding/removing/editing budgets and funds. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 26130 [details] [review] [PASSED QA] Bug 11675: Budget total is not checked if a parent exists The sth is created before the query. The query was modified after the sth creation and an error was raised. Test plan: 0/ Don't apply the patch 1/ Create a budget A (amount=1000) 2/ Create a fund A1 (amount=1000) 3/ Create a child fund A11 (amount=1000) 4/ Edit A11 and change the amount to 2000 You are able to do it, an error appears in the Koha log: "check_parent_total.pl: DBD::mysql::st execute failed: called with 2 bind variables when 1 are needed" 5/ Apply the patch, edit A11 and save. You get an error 6/ Edit A11 and change the amount to <=1000 7/ Verify that there is no regression on adding/removing/editing budgets and funds. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Works as described, no regressions found.
Pushed to master. Thanks, Jonathan!
Pushed to 3.14.x, will be in 3.14.07
Pushed to 3.12.x will be in 3.12.13