Unsecured content on secured pages for opac-readingrecord and opac-user templates. Patches to follow.
Created attachment 25043 [details] [review] bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: * Enable Amazon images in the system preferences * Issue a book you know will have images for, verify that without SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok
Some of these changes do not solve the problem. The issue is http vs. https.
Created attachment 26848 [details] [review] bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: In both prog and bootstrap: * Enable Amazon images in the system preferences * Issue a book you know will have images for, verify that without SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses http:// 3. the images are the right size, and look ok * Do the same using https, verify that with SSL 1. the images show on the borrower's logged in home page (opac-user, both checkouts and overdue tab) and on the opac-readingrecord 2. the image source is from an Amazon url that uses https:// 3. the images are the right size, and look ok
Created attachment 26852 [details] [review] [SIGNED OFF] bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: 0) It goes without saying that images being looked at should continue to be the proper size and look ok. 1) In the staff client, change the OPAC system preference opacthemes to 'bootstrap'. 2) Enable Amazon images in the system preferences 3) Issue a book you know will have images for a known user 4) Issue a book you know will have images for intentionally overdue for the same user 5) git reset --hard origin/master 6) In OPAC, log in as the user. -- On the 'your summary' tab on the left (which is default), a) In the 'Checked out' tab, there should be at least two books. The two books issued should have http images. b) In the 'Overdue' tag, there should be at least one book. The image for the overdue book issued should have http images. 7) Click the 'your reading history' tab on the left. -- The images for the two books issued should have http images. 8) Apply the patch 9) Repeat steps 6-7, but all the images in question should have https images now. 10) In the staff client, change the OPAC system preference opacthemes to 'prog'. 11) Repeat steps 5-9 12) Run the koha QA test tool Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 26888 [details] [review] [PASSED QA] Bug 11684: mixed content warnings using SSL with amazon - opac-readingrecord and opac-user To test: 0) It goes without saying that images being looked at should continue to be the proper size and look ok. 1) In the staff client, change the OPAC system preference opacthemes to 'bootstrap'. 2) Enable Amazon images in the system preferences 3) Issue a book you know will have images for a known user 4) Issue a book you know will have images for intentionally overdue for the same user 5) git reset --hard origin/master 6) In OPAC, log in as the user. -- On the 'your summary' tab on the left (which is default), a) In the 'Checked out' tab, there should be at least two books. The two books issued should have http images. b) In the 'Overdue' tag, there should be at least one book. The image for the overdue book issued should have http images. 7) Click the 'your reading history' tab on the left. -- The images for the two books issued should have http images. 8) Apply the patch 9) Repeat steps 6-7, but all the images in question should have https images now. 10) In the staff client, change the OPAC system preference opacthemes to 'prog'. 11) Repeat steps 5-9 12) Run the koha QA test tool Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Checked reading history, overdoes, and checkouts in bootstrap and prog OPAC. Amazon image URL is now https://.
It seems the same stuff is done on bug 8952.
Similar, but not the same.
Pushed to master. Thanks, Liz!