Bug 11684 - More mixed content warnings using SSL with amazon - opac-readingrecord and opac-user
Summary: More mixed content warnings using SSL with amazon - opac-readingrecord and op...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 01:00 UTC by Liz Rea
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user (6.00 KB, patch)
2014-02-05 01:04 UTC, Liz Rea
Details | Diff | Splinter Review
bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user (9.19 KB, patch)
2014-04-06 22:57 UTC, Liz Rea
Details | Diff | Splinter Review
[SIGNED OFF] bug 11684 - mixed content warnings using SSL with amazon - opac-readingrecord and opac-user (9.75 KB, patch)
2014-04-07 03:28 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 11684: mixed content warnings using SSL with amazon - opac-readingrecord and opac-user (9.99 KB, patch)
2014-04-07 21:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2014-02-05 01:00:44 UTC
Unsecured content on secured pages for opac-readingrecord and opac-user templates.

Patches to follow.
Comment 1 Liz Rea 2014-02-05 01:04:07 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-03-17 20:59:33 UTC
Some of these changes do not solve the problem. The issue is http vs. https.
Comment 3 Liz Rea 2014-04-06 22:57:43 UTC Comment hidden (obsolete)
Comment 4 Mark Tompsett 2014-04-07 03:28:04 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-04-07 21:28:04 UTC
Created attachment 26888 [details] [review]
[PASSED QA] Bug 11684: mixed content warnings using SSL with amazon - opac-readingrecord and opac-user

To test:

 0) It goes without saying that images being looked at should
    continue to be the proper size and look ok.
 1) In the staff client, change the OPAC system preference
     opacthemes to 'bootstrap'.
 2) Enable Amazon images in the system preferences
 3) Issue a book you know will have images for a known user
 4) Issue a book you know will have images for intentionally
     overdue for the same user
 5) git reset --hard origin/master
 6) In OPAC, log in as the user.
    -- On the 'your summary' tab on the left (which is default),
       a) In the 'Checked out' tab, there should be at least two
          books. The two books issued should have http images.
       b) In the 'Overdue' tag, there should be at least one
          book. The image for the overdue book issued should
          have http images.
 7) Click the 'your reading history' tab on the left.
    -- The images for the two books issued should have
       http images.
 8) Apply the patch
 9) Repeat steps 6-7, but all the images in question should
    have https images now.
10) In the staff client, change the OPAC system preference
     opacthemes to 'prog'.
11) Repeat steps 5-9
12) Run the koha QA test tool

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
Checked reading history, overdoes, and checkouts in
bootstrap and prog OPAC. Amazon image URL is now https://.
Comment 6 Jonathan Druart 2014-04-08 11:02:16 UTC
It seems the same stuff is done on bug 8952.
Comment 7 Mark Tompsett 2014-04-08 17:23:14 UTC
Similar, but not the same.
Comment 8 Galen Charlton 2014-05-05 03:23:55 UTC
Pushed to master.  Thanks, Liz!