Bug 11685 - GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe
Summary: GetSupportName and GetSupportList do not split AdvancedSearchTypes by pipe
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 07:31 UTC by paxed
Modified: 2017-06-14 22:10 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-02-05 07:31:47 UTC
System preference AdvancedSearchTypes can be a pipe-separated list of values.
GetSupportName() and GetSupportList() compare the syspref value directly using eq instead of using a regex, or splitting the value by pipe and then comparing the array values.

For example, this can mean the "Item type" drop down is empty in OPAC when entering a new purchase suggestion.
Comment 1 paxed 2014-04-24 09:36:46 UTC
In addition to GetSupportName(), GetSupportList() in C4/Koha.pm, also opac/opac-topissues.pl handles the syspref wrongly.
Comment 2 Marc Véron 2014-04-24 19:04:30 UTC
- I think it is a bug, not an enhancement.
- For opac/opac-topissues.pl I filed a separate bug (12136)
Comment 3 Jonathan Druart 2016-08-15 15:24:36 UTC
No longer valid, these 2 subs have been removed.