Bug 11686 - "please note your reason here..." does not get translated
Summary: "please note your reason here..." does not get translated
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-05 08:52 UTC by paxed
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11686 - "please note your reason here..." does not get translated (2.86 KB, patch)
2014-02-05 16:02 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11686 - "please note your reason here..." does not get translated (2.87 KB, patch)
2014-02-28 17:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11686 - "please note your reason here..." does not get translated (3.03 KB, patch)
2014-03-12 10:53 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description paxed 2014-02-05 08:52:16 UTC
Even though the text "please note your reason here..." (in suggestion.tt) will get picked up into the po-files, it is never actually translated in the templates when you install the language.
Comment 1 Owen Leonard 2014-02-05 16:02:07 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-02-28 17:47:13 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-12 10:53:48 UTC
Created attachment 26157 [details] [review]
[PASSED QA] Bug 11686 - "please note your reason here..." does not get translated

Through some quirk of the translation script a predefined value on a
text input is not properly translated even though the string appears in
the po file. On the suggestions form the problem can be solved by using
the HTML5 placeholder attribute.

To test you must have existing suggestions to manage. Apply the patch
and:

- Update a translation by running tranlsate update [language code]
- Install/reinstall the translation by running translate install
  [language code]

- In the English templates:

  - Navigate to Acquisitions -> Suggestions and find the "Mark selected
    as:" section below the table of existing suggestions.
  - Select "Other" from the "choose a reason" field. A text input field
    should appear with the placeholder text "please note your reason
    here."

- In the templates you updated and installed, follow the same procedure
  above. The placeholder text should now appear with the correct
  translation.
- In both English and translated templates using this bulk-status option
  should save your chosen status correctly with the correct reason,
  whether that reason be predefined or manually entered.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script.
Tested successfully with German - nice to see this fixed!
Comment 4 Galen Charlton 2014-03-12 14:57:24 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-04 09:32:45 UTC
Pushed to 3.14.x, will be in 3.14.08