On bug 10832 comment 12, a specific cause an issue. If email, print and sms are checked (for overdues for instance), and no email exists for the user, the email template will be used to sent the print notice. The print notices should be processed in first to avoid this problem.
Created attachment 25069 [details] [review] Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template.
Created attachment 25070 [details] [review] Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Pretty slick solution! gg
Created attachment 27530 [details] [review] Bug 11696: The print notices should be processed in first This reorder avoids to sent a print notice with an email or sms template is no email or sms is defined. Test plan: Check print, sms and email for an overdue rule Don't define an email address and generate an overdue for a user Define 3 templates for the notice used Launch the cronjob script and verify the print notice is generated using the print template. Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
(In reply to Olli-Antti Kivilahti from comment #3) > Pretty slick solution! This solution works. But I think that in terms of QA and maintenance it is not the most elegant one.
Pushed to master. Thanks, Jonathan!