Bug 11709 - Bootstrap OPAC lists interface requires some revisions
Summary: Bootstrap OPAC lists interface requires some revisions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 14:52 UTC by Owen Leonard
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 11709 - Bootstrap OPAC lists interface requires some revisions (5.15 KB, patch)
2014-02-07 15:39 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed-off] Bug 11709 - Bootstrap OPAC lists interface requires some revisions (5.28 KB, patch)
2014-02-17 20:03 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 11709 - Bootstrap OPAC lists interface requires some revisions (5.33 KB, patch)
2014-02-18 14:25 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-07 14:52:34 UTC
I noticed a couple of issues with the Bootstrap OPAC lists interface:

- The old breadcrumbs from the prog theme are still present
  on the List edit screen.
- New/Edit/Delete controls are missing from the list view
  if the list is empty.
Comment 1 Owen Leonard 2014-02-07 15:39:39 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-02-17 20:03:40 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-18 14:25:37 UTC
Created attachment 25373 [details] [review]
Bug 11709 - Bootstrap OPAC lists interface requires some revisions

This patch makes some revisions to the lists template:

- Removed the old prog theme breadcrumbs from the List edit screen.
- Added New/Edit/Delete controls to the list view in cases where the
  list is empty.
- Corrected some breadcrumb logic.

To test, apply the patch and edit an existing list. You should see a
heading "Editing [list name]".

If necessary create a list with zero items on it. View the list. You
should see New/Edit/Delete links above the message about the list being
empty.

Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-18 23:40:27 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-03 12:53:27 UTC
Pushed to 3.14.x, will be in 3.14.08