Serials templates which use the DataTables plugin should be updated to use the new DataTables include file introduced by Bug 10649.
Created attachment 25178 [details] [review] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting.
Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com>
Created attachment 25600 [details] [review] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Sorting on Call number gives me a Javascript error and the 'little arrow' icons don't change when clicking on them: return a.match(/title="(.*?)"/)[1].toLowerCase();
Created attachment 25619 [details] [review] Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error.
Created attachment 26042 [details] [review] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 26043 [details] [review] Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Hi Owen, I tested and found 2 small things: - On the serials collection page the sort on the Routing column could be removed, this is no reason for a fail, as it's there pre-patch. So just noting :) - On the claims page the sorting is totally broken for me - maybe a side effect of another patch pushed since? Javascript error shown is: TypeError: a.aoColumns[c] is undefined ...null};if("function"===typeof a)return function(b,d,i){return a(b,d,i)};if("strin... jquery....min.js (Zeile 29) Since and Claim date don't show the little arrow for sorting.
Created attachment 27145 [details] [review] Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page.
Leaving this one for Katrin to test as she already seems to be up on it :)
Ah, please don't - then I can come back to do QA ;)
Created attachment 27535 [details] [review] Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
I am having problems resolving the conflict here correctly - sorry.
Created attachment 27733 [details] [review] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 27734 [details] [review] Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Created attachment 27735 [details] [review] Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 27737 [details] [review] [PASSED QA] Bug 11719 - Use new DataTables include in serials templates Bug 10649 introduced a new include file for adding DataTables-related JavaScript assets. This patch adds use of this include file to all serials-related pages which use DataTables. Apply the patch and test the following pages to confirm that table sorting works correctly: - Serials search results (serials/serials-search.pl): Perform a search which will return more than one subscription. The expiration date column is now sorted using the "title-string" filter for sorting based on the unformatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. - Serials collection (serials/serials-collection.pl): View the serial colection page for an existing subscription. The table of issues should be sorted correctly. - Serial claims (serials/claims.pl): The "since" and "claim date" columns have been modified to use the title-string filter for sorting based on the unformatted date. C4::Serials.pm::GetLateOrMissingIssues has been modified to pass an unformatted date along with the formatted date. The "anti-the" filter has been added to the title column to exclude articles when sorting. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested all 3 tables, no regressions found. Passes QA script and tests.
Created attachment 27738 [details] [review] [PASSED QA] Bug 11719 [Follow-up] Use new DataTables include in serials templates This patch corrects column sorting configuration to avoid an error when sorting on the call number column. Also changed: removed obsolete UK sort mention. To test, search for serial subscriptions. Test sorting on all columns in the results table with and without the RoutingSerials preference enabled. Sorting should work correctly without error. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 27739 [details] [review] [PASSED QA] Bug 11719 [Follow-up 2] Use new DataTables include in serials templates This second follow-up addresses QA issues: - Corrected sorting on claims page while converting sorting configuration to up-to-date method. - Removed sorting from routing list column on serial collection page. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Pushed to master. Thanks, Owen!