Bug 11721 - Use new DataTables include in suggestions template
Summary: Use new DataTables include in suggestions template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/suggestion/suggestion.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-07 19:46 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11721 - Use new DataTables include in suggestions template (2.04 KB, patch)
2014-02-07 21:05 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11721 - Use new DataTables include in suggestions template (2.07 KB, patch)
2014-02-08 04:55 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 11721 - Use new DataTables include in suggestions template (2.26 KB, patch)
2014-02-09 16:39 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-07 19:46:03 UTC
The suggestions template should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-07 21:05:44 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-08 04:55:00 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-09 16:35:45 UTC
Funds and Status column are not sortable before and after the patch - it would be nice if they would be.
Comment 4 Katrin Fischer 2014-02-09 16:39:36 UTC
Created attachment 25157 [details] [review]
[PASSED QA] Bug 11721 - Use new DataTables include in suggestions template

This patch modifies the template for the suggestions page to use
the new DataTables include. This simplifies the inclusion of assets and
updates to the latest DataTables version.

Sorting is now configured to exclude articles when sorting the title
column.

To test, apply the patch and view the suggestions page (Acquisitions ->
Suggestions). Sorting of suggestions should work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

Note: the columsn fund and status are not sortable/searchable
before and after applying the patch.
Comment 5 Galen Charlton 2014-02-10 15:57:11 UTC
Pushed to master.  Thanks, Owen!
Comment 6 Fridolin Somers 2014-05-19 13:48:13 UTC
Pushed to 3.14.x, will be in 3.14.07.