Bug 11724 - Make Funds/Status on suggestions page sortable/searchable
Summary: Make Funds/Status on suggestions page sortable/searchable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/suggestion/suggestion.pl
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-09 16:41 UTC by Katrin Fischer
Modified: 2014-12-07 20:07 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11724 - Make Funds/Status on suggestions page sortable/searchable (2.22 KB, patch)
2014-03-14 19:08 UTC, Owen Leonard
Details | Diff | Splinter Review
[Signed off] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable (2.27 KB, patch)
2014-04-24 02:42 UTC, David Cook
Details | Diff | Splinter Review
[PASSED QA] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable (2.37 KB, patch)
2014-04-26 12:54 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-02-09 16:41:50 UTC
The 2 last columns in the suggestions table in staff are not sortable. Also, if you enter the fund name in the datatable search box on top of the table, it will not match.
Comment 1 Owen Leonard 2014-03-14 19:08:45 UTC Comment hidden (obsolete)
Comment 2 David Cook 2014-04-24 02:42:30 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-04-26 12:49:40 UTC
Comment on attachment 26363 [details] [review]
Bug 11724 - Make Funds/Status on suggestions page sortable/searchable

Please remember to obsolete the original patch when signing off.
Comment 4 Katrin Fischer 2014-04-26 12:54:40 UTC
Created attachment 27651 [details] [review]
[PASSED QA] Bug 11724 - Make Funds/Status on suggestions page sortable/searchable

The fund and status columns on the suggestions page are not sortable or
searchable. This patch makes them so.

This patch also amends the DataTables configuration to use class-based
targeting for sorting types as was decided on the koha-devel list. The
table markup has been modified accordingly.

To test you must have existing suggestions. Apply the patch and go to
Acquisitions -> Suggestions. View the table of existing suggestions and
confirm that the funds and status columns are sortable and searchable.

Confirm that the title column correctly ignores articles when sorting.

Signed-off-by: David Cook <dcook@prosentient.com.au>

Works as described.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, template change only.
Comment 5 Galen Charlton 2014-04-28 17:26:25 UTC
Pushed to master.  Thanks, Owen!