Bug 11730 - C4::Charset call C4::Context without use it
Summary: C4::Charset call C4::Context without use it
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-10 09:48 UTC by Stéphane Delaune
Modified: 2015-06-04 23:30 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
proposed patch (598 bytes, patch)
2014-02-10 09:58 UTC, Stéphane Delaune 		Details | Diff | Splinter Review
Bug 11730: C4-Charset call C4-Context without use it (643 bytes, patch)
2014-02-14 07:00 UTC, Chris Cormack 		Details | Diff | Splinter Review
Bug 11730: C4-Charset call C4-Context without use it (709 bytes, patch)
2014-02-14 14:03 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stéphane Delaune 2014-02-10 09:48:56 UTC 
C4::Charset call C4::Context without use it ; so when a script call SetMarcUnicodeFlag it returen : "Can't locate object method "preference" via package "C4::Context" (perhaps you forgot to load "C4::Context"?) at /home/gboisson/workspace/versions/community/C4/Charset.pm line 330".
Comment 1 Stéphane Delaune 2014-02-10 09:58:20 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-14 07:00:07 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-14 14:03:42 UTC 
Created attachment 25266 [details] [review]
Bug 11730: C4-Charset call C4-Context without use it

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-18 21:53:40 UTC 
Pushed to master.  Thanks, Stéphane!
Comment 5 Galen Charlton 2014-02-18 22:01:45 UTC 
BTW, this bug inspired me to open bug 11790.
Comment 6 Fridolin Somers 2014-05-19 14:32:19 UTC 
Pushed to 3.14.x, will be in 3.14.07
Comment 7 Kyle M Hall (khall) 2014-06-06 13:52:01 UTC 
Pushed to 3.12.x will be in 3.12.13