Bug 11735 - Use new DataTables include in calendar template
Summary: Use new DataTables include in calendar template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/holidays.pl
Keywords:
Depends on:
Blocks: 11720
  Show dependency tree / graph
 
Reported: 2014-02-10 17:56 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11735 - Use new DataTables include in calendar template (2.60 KB, patch)
2014-02-10 18:05 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 11735 - Use new DataTables include in calendar template (2.61 KB, patch)
2014-02-11 03:27 UTC, Biblibre Sandboxes 		Details | Diff | Splinter Review
Bug 11735 - Use new DataTables include in calendar template (2.84 KB, patch)
2014-02-11 08:51 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-10 17:56:56 UTC 
The calendar template should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-10 18:05:25 UTC Comment hidden (obsolete)
Comment 2 Biblibre Sandboxes 2014-02-11 03:27:13 UTC 
Patch tested with a sandbox, by merlissia <manuelimel@gmail.com>
Comment 3 Biblibre Sandboxes 2014-02-11 03:27:31 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-02-11 08:51:26 UTC 
Created attachment 25190 [details] [review]
Bug 11735 - Use new DataTables include in calendar template

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to the
calendar template and corrects some table sorting configuration errors.

To test you should have multiple calendar entries in various categories
of holiday: Unique holidays, repeating yearly holidays, repeating weekly
holidays, and exceptions. Sorting of date columns should work regardless
of your dateformat system preference.

Signed-off-by: merlissia <manuelimel@gmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Note: Day of week is not correctly sorted: Sundays, Mondays, Thursdays.
But it is not a regression. It is caused by the ugly way to display
weekdays (document.write).
Comment 5 Galen Charlton 2014-02-13 16:01:55 UTC 
Pushed to master.  Thanks, Owen!
Comment 6 Fridolin Somers 2014-05-19 14:02:23 UTC 
Pushed to 3.14.x, will be in 3.14.07.