Bug 11740 - Use new DataTables include in quotes upload template
Summary: Use new DataTables include in quotes upload template
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/tools/quotes-upload.pl
Keywords:
Depends on:
Blocks: 11720
  Show dependency tree / graph
 
Reported: 2014-02-10 20:29 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11740 - Use new DataTables include in quotes upload template (2.04 KB, patch)
2014-02-11 13:44 UTC, Owen Leonard 		Details | Diff | Splinter Review
[SIGNED OFF] Bug 11740 - Use new DataTables include in quotes upload template (2.06 KB, patch)
2014-02-18 21:42 UTC, Mark Tompsett 		Details | Diff | Splinter Review
Bug 11740 - Use new DataTables include in quotes upload template (2.14 KB, patch)
2014-02-19 11:06 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-10 20:29:27 UTC 
The quotes upload template should be updated to use the new DataTables include file introduced by Bug 10649.
Comment 1 Owen Leonard 2014-02-11 13:44:35 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-02-18 21:42:34 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-19 11:06:43 UTC 
Created attachment 25438 [details] [review]
Bug 11740 - Use new DataTables include in quotes upload template

Bug 10649 introduced a new include file for adding DataTables-related
JavaScript assets. This patch adds use of this include file to the
quotes upload page.

To test you need a CSV file of quotes to upload ( "source","text" ).
Go to Tools -> Quote editor and click the "Import quotes" button. Upload
the CSV file and confirm that the table which previews the import
results loads correctly. Sorting is not enabled, but pagination and
searching should work.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
No regression found.
Comment 4 Galen Charlton 2014-02-19 17:16:15 UTC 
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-19 14:53:25 UTC 
Pushed to 3.14.x, will be in 3.14.07