Two theme directories contain a copy of the main DataTables plugin which is unused and can be removed: opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.dataTables.min.js opac-tmpl/bootstrap/lib/jquery/plugins/jquery.dataTables.min.js All OPAC templates now use the copy in opac-tmpl/lib/jquery/plugins/
Created attachment 25207 [details] [review] Bug 11743 - Remove unused DataTables plugin from OPAC theme directories The Bootstrap and CCSR theme directories contain older copies of the DataTables plugin which is no longer in use. This patch removes them both. To test, apply the patch and confirm that DataTables still work on the following pages in both the Bootstrap and CCSR OPAC themes: - The Cart. Add items to the Cart, open it and confirm that the table is sorted correctly. - The detail page: View the detail page for a title (opac-detail.pl) with multiple items and confirm that the table of items is sorted correctly. - A subscription's "full history" page: Navigate to the detail page of a subscription in your catalog which has received multiple issues. From the subscriptions tab click the "More details" link, then the "Full history" link. Confirm that the table of issues is sorted correctly. - Search history: Enable the EnableOpacSearchHistory system preference. Perform a few searches so that your current session will record them. View the search history page and confirm that the tables of current and past searches are sorted correctly. - Suggestions (enable 'suggestion' system pref if necessary) - Tags (enable TagsEnabled if necessary) - Most popular (enable OpacTopissue if necessary) - User summary (opac-user.pl): Checkouts, overdues, and holds tables should all sort correctly. - Self checkout: Enable WebBasedSelfCheck if necessary. Check out as a patron who has multiple existing checkouts. Confirm that the table is sorted correctly.
Created attachment 25312 [details] [review] Bug 11743 - Remove unused DataTables plugin from OPAC theme directories The Bootstrap and CCSR theme directories contain older copies of the DataTables plugin which is no longer in use. This patch removes them both. To test, apply the patch and confirm that DataTables still work on the following pages in both the Bootstrap and CCSR OPAC themes: - The Cart. Add items to the Cart, open it and confirm that the table is sorted correctly. - The detail page: View the detail page for a title (opac-detail.pl) with multiple items and confirm that the table of items is sorted correctly. - A subscription's "full history" page: Navigate to the detail page of a subscription in your catalog which has received multiple issues. From the subscriptions tab click the "More details" link, then the "Full history" link. Confirm that the table of issues is sorted correctly. - Search history: Enable the EnableOpacSearchHistory system preference. Perform a few searches so that your current session will record them. View the search history page and confirm that the tables of current and past searches are sorted correctly. - Suggestions (enable 'suggestion' system pref if necessary) - Tags (enable TagsEnabled if necessary) - Most popular (enable OpacTopissue if necessary) - User summary (opac-user.pl): Checkouts, overdues, and holds tables should all sort correctly. - Self checkout: Enable WebBasedSelfCheck if necessary. Check out as a patron who has multiple existing checkouts. Confirm that the table is sorted correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 25341 [details] [review] Bug 11743 - Remove unused DataTables plugin from OPAC theme directories The Bootstrap and CCSR theme directories contain older copies of the DataTables plugin which is no longer in use. This patch removes them both. To test, apply the patch and confirm that DataTables still work on the following pages in both the Bootstrap and CCSR OPAC themes: - The Cart. Add items to the Cart, open it and confirm that the table is sorted correctly. - The detail page: View the detail page for a title (opac-detail.pl) with multiple items and confirm that the table of items is sorted correctly. - A subscription's "full history" page: Navigate to the detail page of a subscription in your catalog which has received multiple issues. From the subscriptions tab click the "More details" link, then the "Full history" link. Confirm that the table of issues is sorted correctly. - Search history: Enable the EnableOpacSearchHistory system preference. Perform a few searches so that your current session will record them. View the search history page and confirm that the tables of current and past searches are sorted correctly. - Suggestions (enable 'suggestion' system pref if necessary) - Tags (enable TagsEnabled if necessary) - Most popular (enable OpacTopissue if necessary) - User summary (opac-user.pl): Checkouts, overdues, and holds tables should all sort correctly. - Self checkout: Enable WebBasedSelfCheck if necessary. Check out as a patron who has multiple existing checkouts. Confirm that the table is sorted correctly. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Existing uses of datatables.min.js don't point to the theme directory.
Pushed to master. Thanks, Owen!
Pushed to 3.14.x, will be in 3.14.07