Bug 11743 - Remove unused DataTables plugin from OPAC theme directories
Summary: Remove unused DataTables plugin from OPAC theme directories
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-11 18:02 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11743 - Remove unused DataTables plugin from OPAC theme directories (139.96 KB, patch)
2014-02-12 14:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11743 - Remove unused DataTables plugin from OPAC theme directories (139.97 KB, patch)
2014-02-16 08:40 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11743 - Remove unused DataTables plugin from OPAC theme directories (140.10 KB, patch)
2014-02-17 10:03 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-11 18:02:04 UTC
Two theme directories contain a copy of the main DataTables plugin which is unused and can be removed:

opac-tmpl/ccsr/en/lib/jquery/plugins/jquery.dataTables.min.js
opac-tmpl/bootstrap/lib/jquery/plugins/jquery.dataTables.min.js

All OPAC templates now use the copy in opac-tmpl/lib/jquery/plugins/
Comment 1 Owen Leonard 2014-02-12 14:08:24 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-16 08:40:59 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-17 10:03:54 UTC
Created attachment 25341 [details] [review]
Bug 11743 - Remove unused DataTables plugin from OPAC theme directories

The Bootstrap and CCSR theme directories contain older copies of the
DataTables plugin which is no longer in use. This patch removes them
both.

To test, apply the patch and confirm that DataTables still work on the
following pages in both the Bootstrap and CCSR OPAC themes:

- The Cart. Add items to the Cart, open it and confirm that the table is
  sorted correctly.

- The detail page: View the detail page for a title (opac-detail.pl)
  with multiple items and confirm that the table of items is sorted
  correctly.

- A subscription's "full history" page: Navigate to the detail page of a
  subscription in your catalog which has received multiple issues. From
  the subscriptions tab click the "More details" link, then the "Full
  history" link. Confirm that the table of issues is sorted correctly.

- Search history: Enable the EnableOpacSearchHistory system
  preference. Perform a few searches so that your current session
  will record them. View the search history page and confirm that the
  tables of current and past searches are sorted correctly.

- Suggestions (enable 'suggestion' system pref if necessary)
- Tags (enable TagsEnabled if necessary)
- Most popular (enable OpacTopissue if necessary)

- User summary (opac-user.pl): Checkouts, overdues, and holds tables
  should all sort correctly.
- Self checkout: Enable WebBasedSelfCheck if necessary. Check out as a
  patron who has multiple existing checkouts. Confirm that the table is
  sorted correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Existing uses of datatables.min.js don't point to the theme directory.
Comment 4 Galen Charlton 2014-02-18 21:28:18 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-19 14:22:55 UTC
Pushed to 3.14.x, will be in 3.14.07