As with bug 11625, we should make the default selection for overdue notice/status triggers the logged in library.
Created attachment 25205 [details] [review] Bug 11747 - Default to logged in library for Overdue notice/status triggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries"
Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org>
Created attachment 25297 [details] [review] Bug 11747 - Default to logged in library for Overdue notice/status triggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Created attachment 25347 [details] [review] Bug 11747 - Default to logged in library for Overdue notice/status triggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This behavior is consistent.
Setting to in discussion for the same reason I set bug 11625 to in discussion. I suggest that we use bug 11625 for all discussion, as whatever resolution occurs for that bug will, for the sake of consistency, should become the resolution for this one.
Created attachment 25842 [details] [review] Bug 11747 [QA Followup] - Don't default to branch specific rules if only one branch exists
This depends on 11625 as we are still trying to agree how this should be working.
Created attachment 35466 [details] [review] Bug 11747 - Default to logged in library for Overdue notice/status triggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> This behavior is consistent.
Created attachment 35467 [details] [review] Bug 11747 [QA Followup] - Don't default to branch specific rules if only one branch exists
Created attachment 35468 [details] [review] Bug 11747 [QA Followup 2] - Use system preference to control behavior
I don't think we'll ever get consensus on this, so I think the best way to move forward is to make this behavior controlled via system preferences.
This is blocked by the discussion on bug 11625.
It needs QA with bug 11625.
Bug 11625 does not apply, please also rebase this one.
Created attachment 38112 [details] [review] Bug 11747 [QA Followup 2] - Use system preference to control behavior NOTE: manually corrected sysprefs.sql issue.
Set to signed off from patch doesn't apply, since I believe that's where it should be.
Kyle, I am almost ready to mark bug 11625 and this one as pass qa, but the updatedb entry is not clear. Could you please add a clean patch for each pref (1 updatedb entry + sysprefs.sql + pref template)? This means 1 patch here for DefaultToLoggedInLibraryOverdueTriggers and 1 patch on bug 11625 for DefaultToLoggedInLibraryCircRules.
Created attachment 38279 [details] [review] Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 38280 [details] [review] Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 38281 [details] [review] Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
DefaultToLoggedInLibraryOverdueTriggers is never used in the code?
Created attachment 38346 [details] [review] Bug 11747 [QA Followup] - Use system preference
Applying: Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers /home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace. - When editing overdue notice/status triggers show the fatal: sha1 information is lacking or useless (installer/data/mysql/sysprefs.sql). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge.
(In reply to Marcel de Rooy from comment #23) > Applying: Bug 11747 - Add system preference > DefaultToLoggedInLibraryOverdueTriggers > /home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace. > - When editing overdue notice/status triggers show the > fatal: sha1 information is lacking or useless > (installer/data/mysql/sysprefs.sql). > Repository lacks necessary blobs to fall back on 3-way merge. > Cannot fall back to three-way merge. oops, dependency
Created attachment 43499 [details] [review] Bug 11747 - Add system preference DefaultToLoggedInLibraryOverdueTriggers Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Amended patch: INSERT IGNORE INTO + msg
Created attachment 43500 [details] [review] Bug 11747 - Implement DefaultToLoggedInLibraryOverdueTriggers This patch makes the default circ rules and notices/slips to edit the logged in branch, if one is set. Test Plan: 1) Apply this patch 2) Log into staff side, and set your library 3) Browse to Tools/Overdue notice/status triggers 4) Note the actions displayed are for your library 5) Select "All libraries" 6) Note the actions displayed are for "All libraries" Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 43501 [details] [review] Bug 11747 [QA Followup] - Use system preference Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master!