Bug 11751 - Some code related to "institution" is unused and obsolete
Summary: Some code related to "institution" is unused and obsolete
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
: 11816 (view as bug list)
Depends on: 6712
Blocks: 19714
  Show dependency treegraph
 
Reported: 2014-02-12 15:35 UTC by Jonathan Druart
Modified: 2017-11-29 14:12 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11751: Institution related code is unused and obsolete (8.79 KB, patch)
2014-02-12 15:38 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11751: remove dead code related to handling members of institution patrons (9.69 KB, patch)
2014-02-21 17:06 UTC, Galen Charlton
Details | Diff | Splinter Review
[passed-qa] Bug 11751: remove dead code related to handling members of institution patrons (9.81 KB, patch)
2014-03-11 11:36 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-02-12 15:35:41 UTC
Bug 6712 started to remove some code but some still exists.
Comment 1 Jonathan Druart 2014-02-12 15:38:39 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-02-12 15:39:33 UTC
Could someone confirm this code can be removed?
Comment 3 Galen Charlton 2014-02-21 16:57:52 UTC
*** Bug 11816 has been marked as a duplicate of this bug. ***
Comment 4 Galen Charlton 2014-02-21 17:06:43 UTC Comment hidden (obsolete)
Comment 5 Galen Charlton 2014-02-21 17:08:00 UTC
As you can see from the duplicate bug I filed, I went down /exactly/ the same road before I discovered the existence of this patch.  I've signed off on it.
Comment 6 Brendan Gallagher 2014-03-11 11:36:54 UTC
Created attachment 26098 [details] [review]
[passed-qa] Bug 11751: remove dead code related to handling members of institution patrons

This patch removes some dead code concerning the handling of patrons
that are members of other, institutional patrons.  This code did not
work; removing it clears the field if somebody wants to do a better
implementation of such relationships between patrons.

This patch:

[1] Removes the memberofinstitution system preference.
[2] Removes the following routines:

    C4::Members::get_institutions()
    C4::Members::add_member_orgs() (and removing this routine
    removes a reference to a borrowers_to_borrowers table that
    does not exist).

There should be no changes whatsoever to system functionality with this
patch (with the trivial exception of the absence of the
memberofinstitution system preference).

Test plan:

[1] Look at the code and use grep, git grep, etc. verify this patch
    does not remove something in use.
[2] Verify that there are no regressions upon adding or editing
    a patron record.
[3] Verify that the memberofinstitution system preference has been
    removed

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
Comment 7 Galen Charlton 2014-03-11 15:06:43 UTC
Pushed to master.  Thanks, Jonathan!
Comment 8 Fridolin Somers 2014-05-27 15:27:53 UTC
Too big to push to 3.14, I set as resolved in 3.16.