Bug 11752 - In OPAC, the serials details display the wrong periodicity
Summary: In OPAC, the serials details display the wrong periodicity
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Blou
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-12 16:43 UTC by Blou
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11752 - wrong periodicity in OPAC details (7.32 KB, patch)
2014-02-12 17:17 UTC, Blou
Details | Diff | Splinter Review
Bug 11752 - wrong periodicity in OPAC details (7.37 KB, patch)
2014-02-13 22:34 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11752 - wrong periodicity in OPAC details (7.79 KB, patch)
2014-02-14 15:38 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Blou 2014-02-12 16:43:17 UTC
When in opac-detail.pl, for a serial, if you click "more details", the description written there for the periodicity is wrong.

opac-serial-issues.tt builds the description all wrong based on the entry in subscription.periodicity, that doesn't match the description in subscripion_frequencies.

TESTING
- create/find a serial with a 1/week periodicity (4 in the database)
- Find it in the opac-detail.pl, click "more details" at the bottom
- validate the string.  Before the patch, it will say:
"The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues"

The "every 3 weeks" is clearly wrong.
Comment 1 Blou 2014-02-12 17:17:23 UTC Comment hidden (obsolete)
Comment 2 Blou 2014-02-12 20:56:45 UTC
Additional note to the testing procedure:

- when in opac-detail.pl, you need to select the second tab, "Subscriptions" in order to see the "More details" link at the bottom.

No wonder this very obvious bug was never spotted by anyone...
Comment 3 Chris Cormack 2014-02-13 22:34:55 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-02-14 15:21:34 UTC
It seems periodicityX should not be used anymore.
You have to use the frequency description.

Is the serial/serial-issues.pl a dead script (which refers to periodicityX too)?
Comment 5 Kyle M Hall 2014-02-14 15:38:27 UTC
Created attachment 25280 [details] [review]
Bug 11752 - wrong periodicity in OPAC details

This fixes bootstrap and prog by modifying the description displayed in the OPAC's detail of serials.

TESTING to reproduce
- create/find a serial with a 1/week periodicity (4 in the database)
- Find it in the opac-detail.pl, click "more details" at the bottom
- validate the string.  Before the patch, it will say:
"The current subscription began on 2013-12-06 and is issued every 3 weeks for 26 issues"

The "every 3 weeks" is clearly wrong.
In fact any periodicity chosen would display a wrong description, not matching the intranet.

After the patch, the display is corrected.

As a bonus, the "every 2 years" now has a description, where it had none before.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 6 Kyle M Hall 2014-02-14 16:09:17 UTC
Waiting for a response to the question/comment on comment 4
Comment 7 Blou 2014-02-14 16:22:12 UTC
1) that description is in the database, making its translation ugly if I understand right.
2) this is a patch to a very obvious problem only one user ever noticed.  We patched it while minimizing the effort needed (qa and dev).  Rearchitecturing the way the information goes to the .tt does not fit the community need IMO (since no one ever made those mouse clicks, seemingly).

I can see the benefit long term, if someone has something else to fix in that area.  At this point, we don't.
Comment 8 Jonathan Druart 2014-02-14 16:47:59 UTC
This patch fixes default values (from the installer or updatedb). If values are redefined, the display will be broken too.

An easy way will be to retrieve frequencies.description, but it won't be translatable.

Since it improves the current behavior, I agree to pass QA on it.
Comment 9 Galen Charlton 2014-04-18 21:26:06 UTC
(In reply to Blou from comment #7)
> 1) that description is in the database, making its translation ugly if I
> understand right.
> 2) this is a patch to a very obvious problem only one user ever noticed.  

Only one of /your/ users, perhaps.

> We
> patched it while minimizing the effort needed (qa and dev). 
> Rearchitecturing the way the information goes to the .tt does not fit the
> community need IMO (since no one ever made those mouse clicks, seemingly).

It is perhaps something to be cautious about to make assertions about community needs. I will instead make a concrete point: your patch, while it is an improvement over the current state of affairs, does not account for the fact that nowadays users can readily create additional frequencies.  Consequently, the OPAC serials details page *will* require more work.
Comment 10 Galen Charlton 2014-04-18 21:29:09 UTC
Pushed to master.  Thanks, Philippe!
Comment 11 Galen Charlton 2014-04-18 21:32:15 UTC
See also bug 12108.
Comment 12 Fridolin Somers 2014-08-06 10:31:52 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 13 Kyle M Hall 2014-08-13 14:35:40 UTC
Picked for 3.12.15!