Bug 11760 - In notices, code of road type is used instead of descritpion
Summary: In notices, code of road type is used instead of descritpion
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Sophie MEYNIEUX
QA Contact: Testopia
URL:
Keywords:
Depends on: 7372
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 11:07 UTC by Sophie MEYNIEUX
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
MT11760 : In notices, code of road type is used instead of description (1.38 KB, patch)
2014-02-14 11:20 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
MT11760 : In notices, code of road type is used instead of description (1.38 KB, patch)
2014-02-14 12:33 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 11760 : In notices, code of road type is used instead of description (1.38 KB, patch)
2014-02-15 10:22 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 11760 : In notices, code of road type is used instead of description (1.45 KB, patch)
2014-02-28 17:09 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11760 : In notices, code of road type is used instead of description (1.69 KB, patch)
2014-03-12 16:38 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2014-02-14 11:07:51 UTC
In notices, <<borrowers.streettype>> is replaced by road type code rather than description

With this patch, description is retrieved

This patch needs http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7372
Comment 1 Sophie MEYNIEUX 2014-02-14 11:20:11 UTC Comment hidden (obsolete)
Comment 2 Sophie MEYNIEUX 2014-02-14 12:33:07 UTC Comment hidden (obsolete)
Comment 3 Sophie MEYNIEUX 2014-02-14 12:34:46 UTC
On Jonathan's advice, I change the patch to be more restrictive on <<borrowers.streettype>> substitution.
Comment 4 Sophie MEYNIEUX 2014-02-15 10:22:49 UTC Comment hidden (obsolete)
Comment 5 Sophie MEYNIEUX 2014-02-15 10:23:36 UTC
Typo in bug naming
Comment 6 Kyle M Hall 2014-02-28 17:09:06 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2014-03-12 16:38:23 UTC
Created attachment 26202 [details] [review]
[PASSED QA] Bug 11760 : In notices, code of road type is used instead of description

Test plan :
  - Define a notice containing <<borrowers.streettype>>
  - Trigger an event that generate this notice

Without patch <<borrowers.streettype>> is replaced by ROADTYPE authorised value code. With the patch it is resplaced by its description

This patch needs bug 7372 to be applied

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described, passes tests and QA script.

Note: it seems it's not possible currently to use B_streettype from
the interface, but it might be worth adding it as a follow up for later
use.
Comment 8 Galen Charlton 2014-03-12 18:04:03 UTC
Pushed to master.  Thanks, Sophie!
Comment 9 Fridolin Somers 2014-06-03 10:55:15 UTC
Pushed to 3.14.x, will be in 3.14.08