Bug 11763 - Consolidate fund action links into menu
Summary: Consolidate fund action links into menu
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/admin/aqbudgets.pl
Keywords:
Depends on: 11578
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-14 15:02 UTC by Owen Leonard
Modified: 2014-12-07 20:07 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11763 - Consolidate fund action links into menu (2.91 KB, patch)
2014-02-14 15:12 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11763 - Consolidate fund action links into menu (3.00 KB, patch)
2014-02-14 16:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 11763 - Consolidate fund action links into menu (3.08 KB, patch)
2014-04-29 09:09 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-14 15:02:13 UTC
Similar to the change made in Bug 10615, we should move the Edit/Delete/Add child links to a menu. This will save space and make the links more distinct.
Comment 1 Owen Leonard 2014-02-14 15:12:07 UTC Comment hidden (obsolete)
Comment 2 Jonathan Druart 2014-02-14 16:02:18 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-23 22:07:21 UTC
Hm, it looks like the depending bug is still waiting for sign off?
Comment 4 Jonathan Druart 2014-02-24 12:26:11 UTC
(In reply to Katrin Fischer from comment #3)
> Hm, it looks like the depending bug is still waiting for sign off?

Hm, yes :)
I cannot sign it off, I am the author of the patch.
Comment 5 Katrin Fischer 2014-03-31 16:08:06 UTC
The dependent bug still needs a sign off - hoping to get back to this soon.
Comment 6 Jonathan Druart 2014-04-01 07:29:03 UTC
(In reply to Katrin Fischer from comment #5)
> The dependent bug still needs a sign off - hoping to get back to this soon.

Does someone check the BLOCKED queue?
Comment 7 Katrin Fischer 2014-04-01 18:56:52 UTC
Hm, I was hoping the developers would, but you might be right that it could get lost there. For me I was looking at this bug for the fifth time or so, realizing that I couldn't really test it yet. Someone, please signoff 11578?
Comment 8 Martin Renvoize 2014-04-29 09:09:23 UTC
Created attachment 27770 [details] [review]
[PASSED QA] Bug 11763 - Consolidate fund action links into menu

This patch moves the fund Edit/Delete/Add child links on the fund view
into a pop-up menu, allow the table to be more compact and the links to
be more distinct.

To test you must apply the patches on Bug 11578 if necessary.

Apply the patch and view the funds list page (Administration -> Funds).
For each line there should be an "Actions" menu containing the
Edit/Delete/Add cihld links. Each should function correctly. Test with
inactive budgets shown and hidden.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
It is unusual to open the action list above the button, but it works.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize 2014-04-29 09:09:54 UTC
Simple patch, easy to test. No regressions. Passed
Comment 10 Galen Charlton 2014-05-03 18:35:58 UTC
Pushed to master.  Thanks, Owen!