Similar to the change made in Bug 10615, we should move the Edit/Delete/Add child links to a menu. This will save space and make the links more distinct.
Created attachment 25273 [details] [review] Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden.
Created attachment 25281 [details] [review] Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It is unusual to open the action list above the button, but it works.
Hm, it looks like the depending bug is still waiting for sign off?
(In reply to Katrin Fischer from comment #3) > Hm, it looks like the depending bug is still waiting for sign off? Hm, yes :) I cannot sign it off, I am the author of the patch.
The dependent bug still needs a sign off - hoping to get back to this soon.
(In reply to Katrin Fischer from comment #5) > The dependent bug still needs a sign off - hoping to get back to this soon. Does someone check the BLOCKED queue?
Hm, I was hoping the developers would, but you might be right that it could get lost there. For me I was looking at this bug for the fifth time or so, realizing that I couldn't really test it yet. Someone, please signoff 11578?
Created attachment 27770 [details] [review] [PASSED QA] Bug 11763 - Consolidate fund action links into menu This patch moves the fund Edit/Delete/Add child links on the fund view into a pop-up menu, allow the table to be more compact and the links to be more distinct. To test you must apply the patches on Bug 11578 if necessary. Apply the patch and view the funds list page (Administration -> Funds). For each line there should be an "Actions" menu containing the Edit/Delete/Add cihld links. Each should function correctly. Test with inactive budgets shown and hidden. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> It is unusual to open the action list above the button, but it works. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Simple patch, easy to test. No regressions. Passed
Pushed to master. Thanks, Owen!