Bug 11787 - Use validation plugin when adding new vendor
Summary: Use validation plugin when adding new vendor
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/acqui/supplier.pl?op=enter
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-18 19:50 UTC by Owen Leonard
Modified: 2014-12-07 20:05 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11787 - Use validation plugin when adding new vendor (5.28 KB, patch)
2014-02-18 20:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11787 - Use validation plugin when adding new vendor (5.29 KB, patch)
2014-02-19 00:22 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 11787 - Use validation plugin when adding new vendor (5.35 KB, patch)
2014-02-20 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-18 19:50:23 UTC
The vendor entry form uses custom validation JavaScript which can be easily replaced with HTML5 validation attributes in conjunction with Koha's built-in validation plugin (http://jqueryvalidation.org/documentation/).
Comment 1 Owen Leonard 2014-02-18 20:15:12 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2014-02-19 00:22:13 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-20 09:50:39 UTC
Created attachment 25481 [details] [review]
Bug 11787 - Use validation plugin when adding new vendor

The vendor entry form uses some custom JavaScript which can be removed
in favor of HTML5 validation attributes and Koha's built-in validation
plugin. This patch does so.

Also corrected: Minor validation issue.

To test, apply the patch and go to Acquisitions -> New vendor. Try
submitting the form without entering a vendor name. This should trigger
a validation warning.

Submission of the form with valid data should work correctly. Editing an
existing vendor should also work correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-20 17:07:42 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-05-21 07:59:46 UTC
Pushed to 3.14.x, will be in 3.14.07