Bug 11794 - opacSerialDefaultTab being ignored
Summary: opacSerialDefaultTab being ignored
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-19 17:39 UTC by Nicole C. Engard
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11794 - opacSerialDefaultTab being ignored (6.20 KB, patch)
2014-02-20 16:46 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11794 - opacSerialDefaultTab being ignored (6.40 KB, patch)
2014-03-05 13:38 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11794 - opacSerialDefaultTab being ignored (6.42 KB, patch)
2014-03-10 10:04 UTC, Jesse Maseto
Details | Diff | Splinter Review
Bug 11794 - opacSerialDefaultTab being ignored (6.42 KB, patch)
2014-03-10 10:06 UTC, Jesse Maseto
Details | Diff | Splinter Review
[PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored (6.57 KB, patch)
2014-03-10 11:00 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2014-02-19 17:39:28 UTC
This is true in master and 3.14. If you have  opacSerialDefaultTab  set to show the subscription tab it still shows the holdings tab as default in ccsr and bootstrap.
Comment 1 Owen Leonard 2014-02-20 16:46:14 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-02-25 00:07:23 UTC
Why did you remove it in the auth ones?
Comment 3 Owen Leonard 2014-03-05 13:38:31 UTC Comment hidden (obsolete)
Comment 4 Jesse Maseto 2014-03-10 10:04:26 UTC Comment hidden (obsolete)
Comment 5 Jesse Maseto 2014-03-10 10:06:05 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2014-03-10 11:00:22 UTC
Created attachment 25982 [details] [review]
[PASSED QA] Bug 11794 - opacSerialDefaultTab being ignored

The opacSerialDefaultTab system preference should control whether to
show the holdings or subscriptions tab by default on the detail page for
a serial. This behavior was broken when we last updated jQueryUI because
of a change in the jQueryUI active tab class name.

This patch corrects the class on the detail page and removes the old
class from the authorities detail page (where it was unnecessary
anyway).

To test, view a serial record in the OPAC under various settings of the
opacSerialDefaultTab preference. The default tab should correctly follow
the preference.

Test in prog and Bootstrap themes.

Edit: Rebased on current master. Note that the change to
opac-auth-detail.tt is because the page never has more than one tab,
hence doesn't need the "active" designation.

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested in prog and bootstrap.
All tests and QA script pass.
Comment 7 Galen Charlton 2014-03-10 15:30:12 UTC
Pushed to master.  Thanks, Owen!
Comment 8 Fridolin Somers 2014-05-27 12:42:09 UTC
Pushed to 3.14.x, will be in 3.14.07