Bug 11798 - Problems with column sorting and row visibility in invoices table
Summary: Problems with column sorting and row visibility in invoices table
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jacek Ablewicz
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-20 08:49 UTC by Jacek Ablewicz
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11798 - Problems with column sorting and row visibility in invoices table (2.05 KB, patch)
2014-02-20 09:19 UTC, Jacek Ablewicz
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11798 - Problems with column sorting and row visibility in invoices table (2.40 KB, patch)
2014-02-25 06:18 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 11798 - Problems with column sorting and row visibility in invoices table (2.45 KB, patch)
2014-02-25 10:21 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jacek Ablewicz 2014-02-20 08:49:09 UTC
There are some problems with column sorting and row visibility in invoices table. Symptoms:

1) Sorting on "Billing date" (functionality introduced by bug 10794) doesn't work properly any longer after bug 10401 was pushed (another side-effect being that "Vendor" column is currently not sortable at all).
2) Only "top ten" invoices are always displayed in the table, and it's not possible to change that without missing top/bottom DataTables pagination bars.
(I'm not quite sure it's an error, perhaps it was intended to work like that = a feature, not a bug)?
Comment 1 Jacek Ablewicz 2014-02-20 09:19:40 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-02-25 06:18:30 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-02-25 10:21:27 UTC
Created attachment 25611 [details] [review]
Bug 11798 - Problems with column sorting and row visibility in invoices table

1) Sorting on "Billing date" (functionality introduced by bug 10794)
doesn't work properly any longer after bug 10401 was pushed (another
side-effect being that "Vendor" column is currently not sortable
at all).
2) Only "top ten" invoices are always displayed in the table, and it's
not possible to change that without missing top/bottom DataTables
pagination bars.

This patch fixes sorting for "Billing date" &  "Vendor" columns
in invoices table and restores the ability to see all table
rows/search results (not just "top ten").

Test plan (you'll need to have 11+ invoices with various billing
dates entered in the system):
1) apply patch,
2) view the Acquisitions invoices page (acqui/invoices.pl), do some
search (= as broad search as possible) and confirm that "Billing
date" and "Vendor" columns now do sort correctly,
3) in situations when there are more then 10 search results, they
should all be visible in the invoices table.

NOTE: Generating invoices is a painfully convoluted mess.
      All my "Billing date" entries were blank, so was not
      able to confirm Billing date issues. However, Vendor
      sorting issues, seeing more than 10, and in my bizarre
      initial case the non-visible checkboxes were all fixed.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Galen Charlton 2014-02-27 16:23:19 UTC
Pushed to master.  Thanks, Jacek!
Comment 5 Fridolin Somers 2014-05-27 10:34:05 UTC
Pushed to 3.14.x, will be in 3.14.07