If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit.
Created attachment 25507 [details] Pre-patch
Created attachment 25508 [details] Post-patch
Created attachment 25509 [details] [review] Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch"
test done on sandbox today : 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) Before applying patch, message on "request.pl = wainting to be pulled After applying patch, message on "request.pl = Item being transferred to XXX So it seems OK
Patch tested with a sandbox, by Nadine Michot <nmichot@voila.fr>
Created attachment 26086 [details] [review] DBIC version - Bug 11801 - In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Nadine Michot <nmichot@voila.fr>
Since I disagree with the idea to call Koha::Database directly from pl scripts, I disagree with this patch :) Moreover, in my opinion it is useless to get the transfer using DBIC, we have a C4::Circulation::GetTransfers routine. The patch works as expected :) Galen and/or others QAers, could you please take a position on that? I will provide a counter patch.
Created attachment 26481 [details] [review] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch"
(In reply to Jonathan Druart from comment #7) > Since I disagree with the idea to call Koha::Database directly from pl > scripts, I disagree with this patch :) > Moreover, in my opinion it is useless to get the transfer using DBIC, we > have a C4::Circulation::GetTransfers routine. > > The patch works as expected :) > > Galen and/or others QAers, could you please take a position on that? I have no problem invoking Koha::Database directly from scripts. Not every bit of database access needs to be wrapped in middleware. However, I will say that if I were doing it via DBIC, I would probably add an at_destination method to the Koha::Schema::Result::Reserves class. That said, I have a stronger aversion to having multiple ways of asking the same question. GetTransfers() gets the job done.
Created attachment 28664 [details] [review] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 28670 [details] [review] [PASSED QA] Bug 11801: In transit hold items incorrectly labels as "Waiting to be pulled" on request.pl If an item needs to be transferred to fill a hold, the hold will be listed as 'Waiting to be pulled" while it is in transit. Test Plan: 1) Place a hold for pickup at another library 2) Check in the item, confirm the hold transfer 3) View the holds for that record ( request.pl ) 4) Note the priority is "In transit" and the status is 'Waiting to be pulled". 5) Apply this patch 6) Reload the holds page 7) Note the status is now "Item being transferred to $branch" Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Works as advertised and passes qa scripts. I'm also happier with the alternative patch using existent routines. I'm an advocate of dbic, but in this case I think as galen rightly states we should all have an aversion to having multiple ways of asking the same question. Nice work guys
Patch pushed to master. I also prefer using GetTransfers. Thanks Jonathan!
Pushed to 3.16.x for inclusion in 3.16.1.