Bug 11802 - Patron purchase suggestions page requires some corrections
Summary: Patron purchase suggestions page requires some corrections
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL: /cgi-bin/koha/members/purchase-sugges...
Keywords:
Depends on: 9261
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-20 15:19 UTC by Owen Leonard
Modified: 2015-06-04 23:23 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11802 - Patron purchase suggestions page requires some corrections (3.70 KB, patch)
2014-02-20 15:26 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11802 - Patron purchase suggestions page requires some corrections (3.72 KB, patch)
2014-03-10 12:09 UTC, Jesse Maseto
Details | Diff | Splinter Review
Bug 11802 - Patron purchase suggestions page requires some corrections (3.80 KB, patch)
2014-03-10 13:17 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-20 15:19:21 UTC
The purchase suggestions page for an individual patron (members/purchase-suggestions.pl) has some errors:

- The patron image doesn't appear
- The button toolbar markup isn't correct
- Unescaped ampersands triggering validation errors
Comment 1 Owen Leonard 2014-02-20 15:26:00 UTC Comment hidden (obsolete)
Comment 2 Jesse Maseto 2014-03-10 12:09:37 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-03-10 13:17:10 UTC
Created attachment 26001 [details] [review]
Bug 11802 - Patron purchase suggestions page requires some corrections

This patch corrects some errors with the staff client's patron purchase
suggestions page (members/purchase-suggestions.pl).

To test, apply the patch and make sure the patronimages system
preference is enabled.

- View the purchase suggestions page for a patron whose record has a
  patron image attached. The image should appear in the left-hand
  sidebar.

- View the page for a patron who has submitted no purchase suggestions.
  The message should be styled correctly.

- The toolbar on the page should look correct and work correctly.

Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-03-10 13:25:18 UTC
While testing this patch, I found a bug on uploading a picture for a patron, see bug 11917.
Comment 5 Galen Charlton 2014-03-10 15:13:08 UTC
Pushed to master.  Thanks, Owen!
Comment 6 Fridolin Somers 2014-05-27 12:17:13 UTC
Was released with 3.16.00.
Depends on 9261, which is not in 3.14.x.