Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap)
Summary: Input fields in OPAC suggestion form are a bit short (Bootstrap)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-21 12:00 UTC by Katrin Fischer
Modified: 2015-06-04 23:33 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) (87.71 KB, patch)
2014-06-27 15:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) (87.84 KB, patch)
2014-06-28 19:52 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap) (87.94 KB, patch)
2014-06-28 20:03 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-02-21 12:00:31 UTC
The input fields for suggestions in the OPAC are a bit short in the bootstrap theme.
Comment 1 Owen Leonard 2014-06-27 15:44:41 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-06-28 19:52:48 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-06-28 20:03:35 UTC
Created attachment 29350 [details] [review]
[PASSED QA] Bug 11810 - Input fields in OPAC suggestion form are a bit short (Bootstrap)

The default Bootstrap input size (absent any specific input size or
class) is too short for the suggestion form. This patch adds a Bootstrap
class to fields which need more room and adjusts the OPAC CSS to allow
for better handling of input width at lower screen widths.

To test apply the patch and clear your browser cache if necessary. Open
the "new suggestion" form in the OPAC and confirm that the entry fields
for title, author, publisher, and collection title are sized well.

Adjust the width of your browser window up and down to confirm that the
field sizes adjust well at various screen widths.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works nicely, no problems found.
Comment 4 Tomás Cohen Arazi 2014-06-30 19:36:06 UTC
Pushed to master, along with a followup of the resulting regenerated opac.css for bootstrap.

Thanks Owen!

FTR: on recent versions (1.7.3) of LESS, the '-x' switch should be used instead of '--yui-compress' (which has been deprecated.