Bug 11812 - Add missing "required" indicator to fields which are required
Summary: Add missing "required" indicator to fields which are required
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-21 14:34 UTC by Owen Leonard
Modified: 2015-06-04 23:33 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Medium patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11812 - Add missing "required" indicator to fields which are required (17.84 KB, patch)
2014-02-21 15:09 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIgned-off] Bug 11812 - Add missing "required" indicator to fields which are required (17.97 KB, patch)
2014-02-23 20:40 UTC, Marc Véron
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11812 - Add missing "required" indicator to fields which are required (18.96 KB, patch)
2014-10-14 13:21 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 11812 - Add missing "required" indicator to fields which are required (18.99 KB, patch)
2014-10-14 13:40 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2014-02-21 14:34:24 UTC
Some form fields are configured to be required but lack the "required" note next to them. Since the red label color may not be immediately understood to indicate that a field is required the "required" text should be present too.
Comment 1 Owen Leonard 2014-02-21 15:09:11 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-02-23 20:40:49 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-23 22:25:21 UTC
1) MARC modification templates - 'This field is required' is not bold like on other pages. 

2) Batch patrons modification - I am not sure if the markup here is not misleading. The fields are required, so you are not allowed to delete their content, but you are not required to actually add something into the fields on this form. You can leave them empty.

3) Some pages still have the Javascript pop up while others do not, but I assume this is going to be tackled with other patches :)

Failing for 2) - Owen, could you take a look please?
Comment 4 Owen Leonard 2014-10-14 13:21:10 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-10-14 13:38:50 UTC
There is something a bit different on the patron category form - if you try saving without filling out any of the fields, the markup doesn't change - there is no additional note or highlighting appearing.

I am still going to pass this, as this is just a small visual problem, but overall I found no regressions or problems.
Comment 6 Katrin Fischer 2014-10-14 13:40:38 UTC
Created attachment 32311 [details] [review]
[PASSED QA] Bug 11812 - Add missing "required" indicator to fields which are required

Form fields in the staff client which are required should be configured
to be so by doing several things:

- Add a class "required" to the field's <label>
- Add a class "required" to the form field
- Add 'required="required"' to the form field
- Apppend a <span class="required">Required</span> after the form field.

Several places in the templates are missing the <span>. This patch adds
them.

To test, apply the patch and view the following pages to confirm that
the "Required" text appears:

- Acquisitions -> Add an order to a basket from a new (empty) record.
  Title, quantity, and fund should indicate they are required.

- Administration -> Authority types ->  New authority type. The
  authority type and description fields should indicate they are
  required.

- Administration -> Authority types -> MARC structure -> New tag. The
  tag field should indicate it is required.

- Patron types and categories -> New category. Category code,
  description, and category type should indicate that they are required.
  FIXME: Enrollment period is required but the user must choose one. I'm
  not sure how to handle that clearly.

- Tools -> CSV profiles. Profile name, profile type, and profile MARC
  fields should indicate they are required on both the new and edit
  forms.

- Administration -> Manage MARC modification templates. Under "Create a
  new template" the name field should indicate that it is required.

- Tools -> Batch patron modification -> Submit a batch for editing. Any
  fields which are required according to your BorrowerMandatoryField
  system preference should indicate that they are required.

Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

QA Edits: Re-worded the "required" not on the batch patron edit form,
added a missing word to the help text on that page. On the csv-profiles
page I removed an unnecessary "javascript:" protocol from the markup.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works and passes QA script.
Comment 7 Tomás Cohen Arazi 2014-10-22 17:33:06 UTC
Patch pushed to master.

Thanks Owen!