Bug 11828 - Add German PDF template for orders in acquisitions
Summary: Add German PDF template for orders in acquisitions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 10746
Blocks: 7267
  Show dependency treegraph
 
Reported: 2014-02-24 14:31 UTC by Katrin Fischer
Modified: 2015-06-04 23:30 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11828: Add German translation of layout2pages PDF template (52.84 KB, patch)
2014-02-26 17:50 UTC, Katrin Fischer
Details | Diff | Splinter Review
[Signed-off] Bug 11828: Add German translation of layout2pages PDF template (53.06 KB, patch)
2014-02-27 19:28 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 11828: Follow up - add new option to OrderPdfFormat (1.24 KB, patch)
2014-03-01 08:35 UTC, Katrin Fischer
Details | Diff | Splinter Review
[Signed-off] Bug 11828: Follow up - add new option to OrderPdfFormat (1.43 KB, patch)
2014-03-06 14:02 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 11828: Add German translation of layout2pages PDF template (53.11 KB, patch)
2014-04-11 10:33 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 11828: Follow up - add new option to OrderPdfFormat (1.48 KB, patch)
2014-04-11 10:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-02-24 14:31:33 UTC
Add a German translation of the existing template layout2pages for creating ordres as PDF in acquisitions.

See also bug 10573.
Comment 1 Katrin Fischer 2014-02-26 17:50:55 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2014-02-27 19:28:27 UTC Comment hidden (obsolete)
Comment 3 Marc Véron 2014-02-27 19:47:01 UTC
The additional German Translation should be reflected in Bug 11459 as well 

OrderPdfFormat pref description could be more verbose
Comment 4 Katrin Fischer 2014-02-27 19:49:26 UTC
I will provide a follow up. :)
Comment 5 Katrin Fischer 2014-03-01 08:35:12 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2014-03-06 14:02:10 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2014-04-11 10:33:31 UTC
Created attachment 27001 [details] [review]
Bug 11828: Add German translation of layout2pages PDF template

To test:
- Switch system preference OrderPdfFormat to pdfformat::layout2pagesde
- Create one or more baskets with some orders each.
- Add all baskets to one basket group
- Print the basket group
- Check everything is translated into German and the formatting/layout
  looks ok

Followed test plan and compared English with German printout.
German version is OK.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2014-04-11 10:33:38 UTC
Created attachment 27002 [details] [review]
Bug 11828: Follow up - add new option to OrderPdfFormat

This depends on bug 11459.

To test:
- Apply patch for 11459
- Apply patches for 11828
- Check appearance of the OrderPdfFormat system preference
  It will offer a pull down with options, including
  "German 2-page"

Followed test plan. Patch behaves as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Jonathan Druart 2014-04-11 10:37:46 UTC
All works great. Tested with bug 7267. Marked as Passed QA.
Comment 10 Galen Charlton 2014-04-11 16:28:29 UTC
Pushed to master.  Thanks, Katrin!
Comment 11 Fridolin Somers 2014-08-06 07:57:28 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 12 Kyle M Hall 2014-08-13 13:52:31 UTC
Picked for 3.12.15!