Bug 11833 - Filtering on saved report subgroup doesn't work
Summary: Filtering on saved report subgroup doesn't work
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-02-24 20:24 UTC by Jesse Maseto
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Report Subgroup (177.62 KB, image/png)
2014-02-24 20:24 UTC, Jesse Maseto
Details
Bug 11833 - Filtering on saved report subgroup doesn't work (1.89 KB, patch)
2014-02-25 21:02 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11833 - Filtering on saved report subgroup doesn't work (2.04 KB, patch)
2014-02-26 06:40 UTC, Mark Tompsett
Details | Diff | Splinter Review
[PASSED QA] Bug 11833 - Filtering on saved report subgroup doesn't work (2.16 KB, patch)
2014-03-12 11:33 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Maseto 2014-02-24 20:24:57 UTC
Created attachment 25597 [details]
Report Subgroup

The reports subgroups feature no longer works.

"No matching reports found" each time I choose a reports subgroup.

I thought it might be because the description name was too long or had a space in it or a hyphen in it or was a branch limited category, but none of those panned out. All subgroups do not work in 3.14. All the groups work when All is selected. But when a subgroup is selected, "no matching reports found" is the result.
Comment 1 Owen Leonard 2014-02-25 21:02:11 UTC Comment hidden (obsolete)
Comment 2 Mark Tompsett 2014-02-26 06:40:34 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-03-12 11:33:54 UTC
Created attachment 26161 [details] [review]
[PASSED QA] Bug 11833 - Filtering on saved report subgroup doesn't work

Filtering the list of saved reports by subgroup doesn't work because the
filtering JavaScript was not updated when the table columns changed with
Bug 3134. This patch corrects the target column for filtering.

To test you must have multiple saved reports within one group, and at
least one of those in a subgroup.

- Apply the patch and go to Reports -> Use saved.
- Click the tab for the group which contains your reports.
- Choose the subgroup you want to filter on from the subgroup dropdown.

The list of reports should be correctly filtered by your subgroup.

NOTE: It seems weird to have the number of columns displayed change
      when filtered, but this patch does correct the filtering.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.
Comment 4 Galen Charlton 2014-03-12 14:58:21 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Fridolin Somers 2014-06-04 09:47:11 UTC
Pushed to 3.14.x, will be in 3.14.08
Comment 6 Kyle M Hall (khall) 2014-06-06 13:59:22 UTC
Pushed to 3.12.x will be in 3.12.13