Add edition and publication year to the order information in PDF templates sent to the vendor.
Created attachment 25703 [details] [review] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before.
Created attachment 25704 [details] [review] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde.
Created attachment 25705 [details] [review] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publié par'
jeudi 13 mars 2014 10:46 The sandbox you've requested is not ready. Some problems occurred applying patches from bug 11859: <h1>Something went wrong !</h1>Applying: Bug 11856: Add publication year and edition to English acq PDF templates Applying: Bug 11856: Add publiction year and edition to German acq PDF template fatal: sha1 information is lacking or useless (acqui/pdfformat/layout2pagesde.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11856: Add publiction year and edition to German acq PDF template When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11859 - Add edition and publication year to PDF templates in acquisitions 25703 - Bug 11856: Add publication year and edition to English acq PDF templates 25704 - Bug 11856: Add publiction year and edition to German acq PDF template 25705 - Bug 11856: Add publiction year and edition to French acq PDF template Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11856-Add-publiction-year-and-edition-to-Germa-_p7StB.patch .
Hi, this needs to be applied on top of a few other patches indicated in the dependencies :)
Created attachment 27470 [details] [review] [SIGNED-OFF] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 27471 [details] [review] [SIGNED-OFF] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 27474 [details] [review] [SIGNED-OFF] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publié par' http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 27723 [details] [review] [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 27724 [details] [review] [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 27725 [details] [review] [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 27726 [details] [review] [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Apart from some issues getting this to apply (just git issues with encoding).. once I did manage then we're good. Passes qa scritps and causes no regressions. A simple enhancement.
Created attachment 27727 [details] [review] [PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 27728 [details] [review] [PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 27730 [details] [review] [PASSED QA] Bug 11856: Add publication year and edition to English acq PDF templates To test: - Switch OrderPdfFormat to pdfformat::layout3pages - Create one or more baskets with a few orders, make sure you are adding some records that contain a publication year and/or edition statement - Close the basket - Create a basket group - Print the PDF and check that edition and publication year show up and bibliographic information is printed correctly - Switch OrderPdfFormat to pdfformat::layout2pages - Repeat PDF print This patch also changes the formatting a bit and differentiates between UNIMARC and MARC21. For MARC21 no additional punctuation is needed as those are cataloged with the information. Only spaces are added for MARC21, while UNIMARC is kept they way it was before. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 27731 [details] [review] [PASSED QA] Bug 11856: Add publiction year and edition to German acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout2pagesde. http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 27732 [details] [review] [PASSED QA] Bug 11856: Add publiction year and edition to French acq PDF template Follow up to the patch for the English templates - repeat tests with OrderPDFFormat set to pdfformat::layout3pagesfr. Additional change: Translates 'published by' to 'publie par' http://bugs.koha-community.org/show_bug.cgi?id=11859 Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Katrin!