Bug 11859 - Add edition and publication year to PDF templates in acquisitions
Summary: Add edition and publication year to PDF templates in acquisitions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on: 7267
Blocks:
  Show dependency treegraph
 
Reported: 2014-02-27 09:57 UTC by Katrin Fischer
Modified: 2014-12-07 20:07 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11856: Add publication year and edition to English acq PDF templates (7.12 KB, patch)
2014-02-27 15:33 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11856: Add publiction year and edition to German acq PDF template (2.67 KB, patch)
2014-02-27 15:33 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 11856: Add publiction year and edition to French acq PDF template (2.84 KB, patch)
2014-02-27 15:33 UTC, Katrin Fischer
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11856: Add publication year and edition to English acq PDF templates (7.22 KB, patch)
2014-04-23 13:08 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11856: Add publiction year and edition to German acq PDF template (2.77 KB, patch)
2014-04-23 13:08 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 11856: Add publiction year and edition to French acq PDF template (2.93 KB, patch)
2014-04-23 13:14 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates (7.25 KB, patch)
2014-04-28 16:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template (2.79 KB, patch)
2014-04-28 16:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates (7.25 KB, patch)
2014-04-28 16:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template (2.79 KB, patch)
2014-04-28 16:42 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11859: Add publication year and edition to English acq PDF templates (7.25 KB, patch)
2014-04-28 16:54 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11859: Add publiction year and edition to German acq PDF template (2.79 KB, patch)
2014-04-28 16:55 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11856: Add publication year and edition to English acq PDF templates (7.24 KB, patch)
2014-04-28 16:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11856: Add publiction year and edition to German acq PDF template (2.79 KB, patch)
2014-04-28 16:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 11856: Add publiction year and edition to French acq PDF template (2.85 KB, patch)
2014-04-28 16:58 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2014-02-27 09:57:57 UTC
Add edition and publication year to the order information in PDF templates sent to the vendor.
Comment 1 Katrin Fischer 2014-02-27 15:33:36 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2014-02-27 15:33:40 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2014-02-27 15:33:43 UTC Comment hidden (obsolete)
Comment 4 Koha Team University Lyon 3 2014-03-13 09:48:27 UTC
 
jeudi 13 mars 2014 10:46
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 11859:
<h1>Something went wrong !</h1>Applying: Bug 11856: Add publication year and edition to English acq PDF templates
Applying: Bug 11856: Add publiction year and edition to German acq PDF template
fatal: sha1 information is lacking or useless (acqui/pdfformat/layout2pagesde.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11856: Add publiction year and edition to German acq PDF template
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 11859 - Add edition and publication year to PDF templates in acquisitions

25703 - Bug 11856: Add publication year and edition to English acq PDF templates
25704 - Bug 11856: Add publiction year and edition to German acq PDF template
25705 - Bug 11856: Add publiction year and edition to French acq PDF template

Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11856-Add-publiction-year-and-edition-to-Germa-_p7StB.patch .
Comment 5 Katrin Fischer 2014-03-13 10:40:29 UTC
Hi, this needs to be applied on top of a few other patches indicated in the dependencies :)
Comment 6 Owen Leonard 2014-04-23 13:08:03 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2014-04-23 13:08:14 UTC Comment hidden (obsolete)
Comment 8 Owen Leonard 2014-04-23 13:14:30 UTC Comment hidden (obsolete)
Comment 9 Martin Renvoize 2014-04-28 16:42:24 UTC Comment hidden (obsolete)
Comment 10 Martin Renvoize 2014-04-28 16:42:30 UTC Comment hidden (obsolete)
Comment 11 Martin Renvoize 2014-04-28 16:42:50 UTC Comment hidden (obsolete)
Comment 12 Martin Renvoize 2014-04-28 16:42:59 UTC Comment hidden (obsolete)
Comment 13 Martin Renvoize 2014-04-28 16:45:04 UTC
Apart from some issues getting this to apply (just git issues with encoding).. once I did manage then we're good.

Passes qa scritps and causes no regressions. A simple enhancement.
Comment 14 Martin Renvoize 2014-04-28 16:54:52 UTC Comment hidden (obsolete)
Comment 15 Martin Renvoize 2014-04-28 16:55:00 UTC Comment hidden (obsolete)
Comment 16 Kyle M Hall 2014-04-28 16:57:35 UTC
Created attachment 27730 [details] [review]
[PASSED QA] Bug 11856: Add publication year and edition to English acq PDF templates

To test:
- Switch OrderPdfFormat to pdfformat::layout3pages
- Create one or more  baskets with a few orders, make sure you
  are adding some records that contain a publication year and/or
  edition statement
- Close the basket
- Create a basket group
- Print the PDF and check that edition and publication year
  show up and bibliographic information is printed correctly
- Switch OrderPdfFormat to pdfformat::layout2pages
- Repeat PDF print

This patch also changes the formatting a bit and differentiates between
UNIMARC and MARC21. For MARC21 no additional punctuation is needed as
those are cataloged with the information. Only spaces are added for MARC21,
while UNIMARC is kept they way it was before.

http://bugs.koha-community.org/show_bug.cgi?id=11859
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 17 Kyle M Hall 2014-04-28 16:57:45 UTC
Created attachment 27731 [details] [review]
[PASSED QA] Bug 11856: Add publiction year and edition to German acq PDF template

Follow up to the patch for the English templates - repeat tests
with OrderPDFFormat set to pdfformat::layout2pagesde.

http://bugs.koha-community.org/show_bug.cgi?id=11859
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 18 Kyle M Hall 2014-04-28 16:58:39 UTC
Created attachment 27732 [details] [review]
[PASSED QA] Bug 11856: Add publiction year and edition to French acq PDF template

Follow up to the patch for the English templates - repeat tests
with OrderPDFFormat set to pdfformat::layout3pagesfr.

Additional change:
Translates 'published by' to 'publie par'

http://bugs.koha-community.org/show_bug.cgi?id=11859
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 19 Galen Charlton 2014-04-28 17:21:01 UTC
Pushed to master.  Thanks, Katrin!