Bug 11868 - Multi transport types: disable sms and phone if not in use
Summary: Multi transport types: disable sms and phone if not in use
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 9016
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-27 14:02 UTC by Jonathan Druart
Modified: 2014-12-07 20:07 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 11868: MTT: disable sms and phone if not in use (3.83 KB, patch)
2014-02-27 14:09 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 11868: MTT: disable sms and phone if not in use (4.37 KB, patch)
2014-03-03 13:38 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 11868: MTT: disable sms and phone if not in use (4.56 KB, patch)
2014-03-03 13:44 UTC, Olli-Antti Kivilahti 		Details | Diff | Splinter Review
[PASSED QA] Bug 11868: MTT: disable sms and phone if not in use (4.61 KB, patch)
2014-04-18 13:33 UTC, Kyle M Hall (khall) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2014-02-27 14:02:40 UTC 
On both pages "Notices and slips" and "Overdue rules", it would be great to disable sms and phone if there are not in use.

What about the "feed" transport type? Is it in use?
Comment 1 Jonathan Druart 2014-02-27 14:09:58 UTC Comment hidden (obsolete)
Comment 2 Olli-Antti Kivilahti 2014-03-03 13:02:27 UTC 
No merge issues here, which is great!

For me the sms and phone checkboxes are disabled even if I have the SMSSendDriver = InaFinland::Driver  &&   TalkingTechItivaPhoneNotification = 1.
Sometimes these systempreferences are not updated in the DB, but I checked for that as well. I activated both and it shows in DB as well. Still sms and phone remain disabled.
Comment 3 Jonathan Druart 2014-03-03 13:38:30 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2014-03-03 13:39:10 UTC 
I forgot the [% USE Koha %]. It should be fixed now.
Comment 5 Olli-Antti Kivilahti 2014-03-03 13:44:17 UTC Comment hidden (obsolete)
Comment 6 Kyle M Hall (khall) 2014-04-18 13:33:45 UTC 
Created attachment 27289 [details] [review]
[PASSED QA] Bug 11868: MTT: disable sms and phone if not in use

On both pages "Notices and slips" and "Overdue rules", it would be great
to disable sms and phone if there are not in use.

Test plan:
1/ Edit a notice
2/ Enable/disable the SMSSendDriver pref and verify the sms block is
enabled/disabled.
3/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
the phone block is enabled/disabled.

4/ Go on tools/overdues.pl
5/ Enable/disable the SMSSendDriver pref and verify the sms checkboxes
are enabled/disabled.
6/ Enable/disable the TalkingTechItivaPhoneNotification pref and verify
the phone checkboxes are enabled/disabled.

Signed-off-by: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>

---------------
Testing report:
---------------
Followed the test plan. Reviewed the code modifications.
Feature works as expected.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 7 Galen Charlton 2014-05-02 21:20:17 UTC 
Pushed to master.  Thanks, Jonathan!