At some point in the past I know that Koha checked the patron category for age restrictions and upperage limits - or so I thought it did. Koha 3.12+ is not checking. It's letting me create patrons that are outside of the date range put on the patron category. I tested in master and 3.12.10
Created attachment 38599 [details] [review] Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it.
Created attachment 38690 [details] [review] [SIGNED OFF]Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org>
Created attachment 38706 [details] [review] [PASSED QA] Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. Signed-off-by: Christopher Brannon <cbrannon@cdalibary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patch pushed to master. Thanks Jonathan!