Created attachment 26200 [details] batch patron modification By having the checkbox to delete a field on the patron modification on the left it implies that you have to click it to select that field to edit. I know the note says not to - but people are doing it. The batch item modification has the checkbox on the right which seems to be clearer.
Created attachment 59835 [details] [review] Bug 11932: Move delete checkbox on patron modification to right To test: 1) Go to Tools -> Batch patron modification 2) Put in a user cardnumber and click Continue 3) Notice checkboxes on the left of the input fields 4) Apply patch and refresh page (resend information if prompted) 5) Notice checkboxes on the right of the input fields 6) Confirm they still work as expected Sponsored-by: Catalyst IT
Created attachment 59891 [details] [review] Bug 11932: Move delete checkbox on patron modification to right To test: 1) Go to Tools -> Batch patron modification 2) Put in a user cardnumber and click Continue 3) Notice checkboxes on the left of the input fields 4) Apply patch and refresh page (resend information if prompted) 5) Notice checkboxes on the right of the input fields 6) Confirm they still work as expected Sponsored-by: Catalyst IT NOTE: Why not left before the label? And while functional, is there a pretty align it nicely with all the other checkboxes CSS styling somehow? Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 60174 [details] [review] Bug 11932: Move delete checkbox on patron modification to right To test: 1) Go to Tools -> Batch patron modification 2) Put in a user cardnumber and click Continue 3) Notice checkboxes on the left of the input fields 4) Apply patch and refresh page (resend information if prompted) 5) Notice checkboxes on the right of the input fields 6) Confirm they still work as expected Sponsored-by: Catalyst IT NOTE: Why not left before the label? And while functional, is there a pretty align it nicely with all the other checkboxes CSS styling somehow? Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
I am not sure it is really an ergonomic improvement, but at least it will make things consistent with batch item mod.
Created attachment 60324 [details] [review] Bug 11932: Move delete checkbox on patron modification to right To test: 1) Go to Tools -> Batch patron modification 2) Put in a user cardnumber and click Continue 3) Notice checkboxes on the left of the input fields 4) Apply patch and refresh page (resend information if prompted) 5) Notice checkboxes on the right of the input fields 6) Confirm they still work as expected Sponsored-by: Catalyst IT NOTE: Why not left before the label? And while functional, is there a pretty align it nicely with all the other checkboxes CSS styling somehow? Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 17.05, thanks Aleisha!
This won't get ported back to 16.11.x as it is an enhancement.