Bug 11934 - Replace given by if-else in Circulation_issuingrules.t
Summary: Replace given by if-else in Circulation_issuingrules.t
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Nicolas Legrand
QA Contact: Galen Charlton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-03-13 09:31 UTC by Nicolas Legrand
Modified: 2015-06-04 23:30 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 11934 - Replace given by if-else statments (3.04 KB, patch)
2014-03-13 09:46 UTC, Nicolas Legrand
Details | Diff | Splinter Review
Bug 11934 - Replace given by if-else statments (3.03 KB, patch)
2014-03-13 10:02 UTC, Nicolas Legrand
Details | Diff | Splinter Review
Bug 11934 - Replace given by if-else statments (3.01 KB, patch)
2014-03-13 10:27 UTC, Nicolas Legrand
Details | Diff | Splinter Review
[SIGNED OFF] Bug 11934 - Replace given by if-else statments (3.09 KB, patch)
2014-03-13 10:30 UTC, Martin Renvoize
Details | Diff | Splinter Review
[PASSED QA] Bug 11934 - Replace given by if-else statments (3.23 KB, patch)
2014-03-13 13:19 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Legrand 2014-03-13 09:31:36 UTC
given statement are to be replaced by if else statements
Comment 1 Nicolas Legrand 2014-03-13 09:46:19 UTC Comment hidden (obsolete)
Comment 2 Nicolas Legrand 2014-03-13 10:02:07 UTC Comment hidden (obsolete)
Comment 3 Nicolas Legrand 2014-03-13 10:27:43 UTC Comment hidden (obsolete)
Comment 4 Martin Renvoize 2014-03-13 10:30:54 UTC
Created attachment 26248 [details] [review]
[SIGNED OFF] Bug 11934 - Replace given by if-else statments

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize 2014-03-13 10:32:55 UTC
Comment on attachment 26242 [details] [review]
Bug 11934 - Replace given by if-else statments

Great work, cleans up code and maintains correct function.

Signed off, go forth and QA
Comment 6 Katrin Fischer 2014-03-13 13:19:04 UTC
Created attachment 26272 [details] [review]
[PASSED QA] Bug 11934 - Replace given by if-else statments

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
replaces given-when with if-elsif-else constructs.
Tests still pass and code looks good.
Comment 7 Galen Charlton 2014-03-13 15:34:23 UTC
Pushed to master, along with a follow-up to tidy up whitespace.

This appears to be your first commit pushed to Koha master.  Congratulations, Nicolas!
Comment 8 Nicolas Legrand 2014-03-13 15:48:03 UTC
Thank you ^^ and thanks to Katrin and Martin who very kindly proposed it to me.
Comment 9 Fridolin Somers 2014-06-12 08:00:22 UTC
Pushed to 3.14.x, will be in 3.14.08

Congratulations Nicolas, you're in stable branch also ;)
Comment 10 Kyle M Hall 2014-06-13 12:44:32 UTC
Pushed to 3.12.x, will be in 3.12.13