Created attachment 26438 [details] [review] Remove spaces in empty indicators when linking an authority to a biblio record. This patch removes spaces in indicators which are imported when we link an authority to a biblio record. The spaces made the indicators harder to edit after the linking, because we had to delete the superfluous space character before a new value could be entered. Test case : * Create of modify a biblio. * Click on the "Tag editor" button for one of the authority field of the biblio. * Search for an existing authority and import it. The selected authority should have a least one empty indicator. * Once the authority is imported into the biblio record, click on the empty indicator field. You should be able to enter a new value without having to delete an unwanted space character. Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
*** Bug 11697 has been marked as a duplicate of this bug. ***
Created attachment 27066 [details] [review] [SIGNED-OFF] Remove spaces in empty indicators when linking an authority to a biblio record. http://bugs.koha-community.org/show_bug.cgi?id=11955 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> To test: 1. Open some authority on editor, save with empty indicators. They are saved as ind1=" " ind2=" " on auth_header tables, with spaces 2. Edit some record, link some tag with previous auth, indicators now have a space on it (or ind1 at last) 3. Apply the patch 4. repeat 2, space is gone Work as described. No koha-qa errors
Created attachment 27227 [details] [review] Bug 11955: Remove spaces in empty indicators when linking an authority to a biblio record. This patch removes spaces in indicators which are imported when we link an authority to a biblio record. The spaces made the indicators harder to edit after the linking, because we had to delete the superfluous space character before a new value could be entered. To test: 1. Open some authority on editor, save with empty indicators. They are saved as ind1=" " ind2=" " on auth_header tables, with spaces 2. Edit some record, link some tag with previous auth, indicators now have a space on it (or ind1 at last) 3. Apply the patch 4. repeat 2, space is gone Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described. No koha-qa errors. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Pushed to master. Thanks, Frédérick!
Pushed to 3.14.x, will be in 3.14.10
Picked for 3.12.15!