Created attachment 26466 [details] [review] Add RMA support for Acquisitions. This patch adds the "Return order" option to the acquisitions menu which lets you print CSV file for Manual RMA management. You can also send RMA notices by email using a configurable notice (code: RMA). Preparation : * Create some vendors with baskets of received items. Make sure your vendors have a valid email address that you control so you can receive the emails we will generate. Test case : * Go in the acquisitions section. * Click on the "Return order" menu item. * Search for a vendor which has some orders. * You should see a table containing basket numbers. Clicking on a line of the table should display the items contained in the basket. Select some items by clicking on their checkboxes. * At the bottom of the page, select the option to export the list to a file (CSV), and click on the "Generate RMA" button. * The CSV should contain some informations on all the items you selected and their booksellers. * Select the option to send an email and click on the "Generate RMA" button. * An email should be sent to all appropriate booksellers. The email should have the format defined in the RMA letter. Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
I've tried to apply against 3.17.00.008 : Applying: Add RMA support for Acquisitions. Using index info to reconstruct a base tree... <stdin>:31: trailing whitespace. "select aqorders.*,aqbasket.*,biblio.*,biblioitems.* from aqorders <stdin>:32: trailing whitespace. LEFT JOIN aqbasket on aqbasket.basketno=aqorders.basketno <stdin>:33: trailing whitespace. LEFT JOIN biblio on aqorders.biblionumber=biblio.biblionumber <stdin>:34: trailing whitespace. LEFT JOIN biblioitems on aqorders.biblioitemnumber=biblioitems.biblioitemnumber <stdin>:333: trailing whitespace. Certains items de la commande seront retournés : warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/letter.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/letter.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql Auto-merging installer/data/mysql/en/mandatory/sample_notices.sql CONFLICT (content): Merge conflict in installer/data/mysql/en/mandatory/sample_notices.sql Auto-merging C4/Letters.pm Failed to merge in the changes. Patch failed at 0001 Add RMA support for Acquisitions. So I pass the patch to "Patch doesn't apply" status.
Created attachment 31381 [details] [review] Bug 11967 - Add support for RMA notices to Acquisitions.
I've applied against master 3.17.00.022 1) On the acquisitions section, I clicked on the "Return order" menu item. "No baskets for this vendor" was shown, whilst there was no current vendor. 2) I asked for a non existent vendor, and Koha answered me "No baskets for this vendor". 3) I asked for a vendor without baskets. Instead of "No baskets for this vendor" Koha sent, beneath the empty result table, the possibility of selecting an "Output" and of clicking "Generate RMA". 4) I asked for a vendor without orders. Instead of a message like "No orders for this vendor" Koha sent, beneath the empty result table, the possibility of selecting an "Output" and of clicking "Generate RMA". 5) On tools I copied the RMA notice to my library Centerville. Then I asked for a vendor with a basket. "Using Notice:" should have listed two options, but there was only one, the "All libraries" notice. 6) I selected some orders and then asked to "Send mail", but the vendor received no mail. 7) After selecting "Generate RMA", no message of feedback was sent: "sent mail"/"problems occurred ..." (see bug 5342). 8) Koha listed the partially received orders too, but perhaps this could be an error. In fact: RMA = "Returning a product in order to receive a refund, replacement, or repair during the product's warranty period". Perhaps RMA should concern only products already received. I asked for a vendor with some partially received orders: these orders were listed. Is it right? 9) In the case of partially received orders, in the result table the row for the received order is exactly the same as the row for the partial received order. So the two orders are not distinct. So I pass the patch to "Failed QA" status.
More reasons to fail qa. This only added it to english and french. This must be added to all sample notices. MY next concern is there are no tests. When you modify a C4 or Koha library, you must have test coverage. The test file t/db_dependent/Letters.t was not modified to include such coverage.
Please close this bz. I would do it but this is not an option I have. The sponsor is not interested in pursuing it. We'll put our energies on other bz.
Hi Blou, I have removed the assigned status and the 'sponsored'. I am hesitating to close this, as it might be a feature someone else might want to work at.
(In reply to Blou from comment #5) > Please close this bz. I would do it but this is not an option I have. > > The sponsor is not interested in pursuing it. We'll put our energies on > other bz. (In reply to Katrin Fischer from comment #6) > Hi Blou, I have removed the assigned status and the 'sponsored'. > > I am hesitating to close this, as it might be a feature someone else might > want to work at. 8 years... no longer hesitating. Code and specifications would probably need a fresh start with all changes since.