Created attachment 26489 [details] [review] Bug 11975: Batch patron deletion code should be improved This patch tries to improve the code for the cleanborrowers.pl tool. - use KohaDates plugin and Koha::DateUtils for date management - replace variables step1, step2 and step3 with step - add a js check if no action if checked Test plan: - Backup your DB - Play with the Patron deletion/anonymisation tool and try to find something inconsistent. If you don't find something different, it works!
Created attachment 28104 [details] [review] Bug 11975: improve the batch patron deletion code This patch tries to improve the code for the cleanborrowers.pl tool. - use KohaDates plugin and Koha::DateUtils for date management, removing a dependency on C4::Dates - replace variables step1, step2 and step3 with step - add a JavaScript check if no action if checked Test plan: - Backup your DB - Play with the Patron deletion/anonymisation tool and try to find something inconsistent. If you don't find something different, it works! Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 28105 [details] [review] Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge() This patch consolidates the code for constructing the parameters for GetBorrowersToExpunge() into a subroutine. As a side-effect, this fixes a regression introduced by the main patch where no patrons would be deleted when filtering by expiration date. To test: [1] Follow the test plan in the main patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Created attachment 28129 [details] [review] [PASSED QA] Bug 11975: improve the batch patron deletion code This patch tries to improve the code for the cleanborrowers.pl tool. - use KohaDates plugin and Koha::DateUtils for date management, removing a dependency on C4::Dates - replace variables step1, step2 and step3 with step - add a JavaScript check if no action if checked Test plan: - Backup your DB - Play with the Patron deletion/anonymisation tool and try to find something inconsistent. If you don't find something different, it works! Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 28130 [details] [review] [PASSED QA] Bug 11975: (follow-up) simplify construction of params for GetBorrowersToExpunge() This patch consolidates the code for constructing the parameters for GetBorrowersToExpunge() into a subroutine. As a side-effect, this fixes a regression introduced by the main patch where no patrons would be deleted when filtering by expiration date. To test: [1] Follow the test plan in the main patch. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Pushed to master. Thanks, Jonathan!