Bug 12023 - Web installer fails under plack
Summary: Web installer fails under plack
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Robin Sheat
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 12173
  Show dependency treegraph
 
Reported: 2014-04-02 03:57 UTC by Robin Sheat
Modified: 2015-06-04 23:30 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 12023 - move InstallAuth.pm to be in C4 (1.35 KB, patch)
2014-04-02 04:22 UTC, Robin Sheat
Details | Diff | Splinter Review
[signed - off] Bug 12023 - move InstallAuth.pm to be in C4 (1.42 KB, patch)
2014-05-21 22:32 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Bug 12023 - move InstallAuth.pm to be in C4 (1.48 KB, patch)
2014-05-22 11:02 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12023: installer - FIX redirect to step 3 (1.06 KB, patch)
2014-05-22 11:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 12023: installer - FIX redirect to step 3 (1.10 KB, patch)
2014-05-23 01:31 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Sheat 2014-04-02 03:57:05 UTC
Could not compile /mnt/catalyst/koha/installer/install.pl: Can't locate InstallAuth.pm in @INC (you may need to install the InstallAuth module) (@INC contains: /mnt/catalyst/koha /etc/perl /usr/local/lib/perl/5.18.2 /usr/local/share/perl/5.18.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.18 /usr/share/perl/5.18 /usr/local/lib/site_perl .) at /mnt/catalyst/koha/installer/install.pl line 7.
BEGIN failed--compilation aborted at /mnt/catalyst/koha/installer/install.pl line 7.
 at /usr/share/perl5/CGI/Compile.pm line 108

This is because InstallAuth.pm is in the installer directory, not C4 where everything else is expected to be.
Comment 1 Robin Sheat 2014-04-02 04:22:33 UTC Comment hidden (obsolete)
Comment 2 Brendan Gallagher 2014-05-21 22:32:33 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2014-05-22 11:02:41 UTC
Created attachment 28421 [details] [review]
Bug 12023 - move InstallAuth.pm to be in C4

InstallAuth was in the installer directory, which meant that plack was
unable to find it, and so running the webinstaller would fail. This
moves it into C4,

Test plan:
* Make sure the web installer runs under plack
* Make sure the web installer runs under non-plack

Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jonathan Druart 2014-05-22 11:03:12 UTC Comment hidden (obsolete)
Comment 5 Robin Sheat 2014-05-23 01:31:59 UTC
Created attachment 28452 [details] [review]
Bug 12023: installer - FIX redirect to step 3

This patch fixes the redirection to step 3.

If you go on installer/install.pl and Koha is already installed,
you should be redirected to the step 3. Without this patch, the
script raised an internal error (500).

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Comment 6 Galen Charlton 2014-05-23 13:23:22 UTC
Pushed to master and 3.16.x.  Thanks Robin and Jonathan!