Bug 12040 - Add STMP authentication parameters to runreports.pl
Summary: Add STMP authentication parameters to runreports.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Nighswonger
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-07 15:36 UTC by Chris Nighswonger
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch to add auth params (2.85 KB, patch)
2014-04-07 15:36 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Patch to add auth params (2.75 KB, patch)
2014-04-07 15:58 UTC, Chris Nighswonger
Details | Diff | Splinter Review
Rebased patch (2.77 KB, patch)
2014-04-07 16:40 UTC, Chris Nighswonger
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication (3.48 KB, patch)
2014-04-07 17:08 UTC, Mark Tompsett
Details | Diff | Splinter Review
Fixup documentation of new params (4.05 KB, patch)
2014-04-07 17:39 UTC, Chris Nighswonger
Details | Diff | Splinter Review
[SIGNED OFF] Bug 12040 - Add 3 parameters for SMTP authentication (4.89 KB, patch)
2014-04-07 18:00 UTC, Mark Tompsett
Details | Diff | Splinter Review
Bug 12040 - Add 3 parameters for SMTP authentication (4.93 KB, patch)
2014-04-11 12:53 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Nighswonger 2014-04-07 15:36:23 UTC Comment hidden (obsolete)
Comment 1 Chris Nighswonger 2014-04-07 15:58:11 UTC
Comment on attachment 26872 [details] [review]
Patch to add auth params

Yikes! Monday strikes again.
Comment 2 Chris Nighswonger 2014-04-07 15:58:56 UTC Comment hidden (obsolete)
Comment 3 Mark Tompsett 2014-04-07 16:18:46 UTC
This may overlap / cause rebase needs with bug 12031.
Comment 4 Chris Nighswonger 2014-04-07 16:40:14 UTC Comment hidden (obsolete)
Comment 5 Mark Tompsett 2014-04-07 17:08:08 UTC Comment hidden (obsolete)
Comment 6 Chris Nighswonger 2014-04-07 17:27:43 UTC
(In reply to M. Tompsett from comment #5)

>       expected parameters. The parameters don't exist before, so
>       I don't see how to pass values for them.

Sorry. Running 'perldoc runreport.pl' should show them up along with all other available params.
Comment 7 Chris Nighswonger 2014-04-07 17:39:20 UTC Comment hidden (obsolete)
Comment 8 Mark Tompsett 2014-04-07 18:00:28 UTC Comment hidden (obsolete)
Comment 9 Kyle M Hall 2014-04-11 12:53:41 UTC
Created attachment 27016 [details] [review]
Bug 12040 - Add 3 parameters for SMTP authentication

-username -> Username to pass to the SMTP server for
              authentication
-password -> Password to pass to the SMTP server for
              authentication
-method   -> Method is the type of authentication.
              Ie. LOGIN, DIGEST-MD5, etc.

Test Plan
---------
As for testing manually using a Gmail account:

1. Set up your sendmail as shown in
    misc/cronjobs/CONFIGURE.gmail

2. Before applying this patch, run misc/cronjobs/runreports.pl
    on your favorite report including the proper email parameters
    against your gmail account.

3. Note the failure message stating the authentication
    requirement.

4. Apply this patch, and return the script including the
    additional parameters and specifying "LOGIN" for the method.

5. Note the successful send.

6. perldoc misc/cronjobs/runreport.pl

7. Run the koha qa test tool.

Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu>
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>

Note: My Mail/Sendmail.pm was in /usr/share/perl5/Mail/Sendmail.pm
      I tested the case with the patch applied, with and without
      expected parameters. The parameters don't exist before, so
      I don't see how to pass values for them.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Galen Charlton 2014-04-11 16:29:28 UTC
Pushed to master.  Thanks, Chris!